Problem/Motivation

Running the upgrade path in combination with core 8.7 -> 8.8 update and the latest pathauto version breaks.

 [notice] Update started: media_entity_update_8201

>  [error]  Argument 2 passed to Drupal\pathauto\AliasStorageHelper::__construct() must be an instance of Drupal\path_alias\AliasRepositoryInterface, instance of Drupal\Core\Path\AliasRepository given 

>  [error]  Update failed: media_entity_update_8201

Proposed resolution

Add an update dependency on system 8803 to ensure the path_alias module is enabled before we run the media upgrade path.

CommentFileSizeAuthor
#11 3131523-11.patch900 byteschr.fritsch
#7 3131523-7.patch631 byteschr.fritsch
#2 3131523.patch419 byteschr.fritsch

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
StatusFileSize
new 3131523.patch419 bytes
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Title: Test: Media upgrade with latest pathauto » Running update path with core 8.8 and pathauto breaks
Issue summary: View changes
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented 
+++ b/media_entity.install
@@ -616,5 +616,6 @@ function media_entity_update_dependencies() {
   // new revision_default field is installed in the correct table.
   $dependencies['media_entity'][8201]['system'] = 8501;
 
+  $dependencies['media_entity'][8201]['system'] = 8803;

So what should the value be 8501 or 8803? :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Related issues: +#1894286: System updates are executed without priority

I think #1894286: System updates are executed without priority would fix this.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
StatusFileSize
new 3131523-7.patch631 bytes

I tested #1894286: System updates are executed without priority and it also works. But I think we should commit and release this quickly.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

LGTM

  • chr.fritsch committed b63efb4 on 8.x-2.x 
    Issue #3131523 by chr.fritsch, alexpott: Running update path with core 8...
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Fixed » Needs review
StatusFileSize
new 3131523-11.patch900 bytes

Because of 8803 doesn't exists on D8.7, the whole update function doesn't run. We need to be smarter here.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks even better to me :)

  • chr.fritsch committed 5485468 on 8.x-2.x 
    Issue #3131523 by chr.fritsch, alexpott: Running update path with core 8...
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Done

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.