Make module compatible with Drupal 9 project installation.

CommentFileSizeAuthor
#9 interdiff_6-8.txt276 bytesmeet_bhanvadia
#9 drupal9_compatibility-3131448-8.patch1.19 KBmeet_bhanvadia
#7 clamav-3131448-6.patch1.21 KBpifagor
#2 3131448-2.patch340 bytesvoleger

Comments

voleger created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Issue summary: View changes
StatusFileSize
new 3131448-2.patch340 bytes
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Active » Needs review
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs review » Reviewed & tested by the community

We have to change \Drupal::service('file_system')->uriScheme($file->destination);, etc...

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Needs work
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs work » Needs review
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
StatusFileSize
new clamav-3131448-6.patch1.21 KB
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented

Patch #7 clamav-3131448-6.patch removes core: 8.x
But as per https://drupal.org/node/3070687 having both keys

core: 8.x
core_version_requirement: ^8 || ^9

Specifies that the module is compatible with all versions of Drupal 8 and 9. The core: is required here because Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

A module that is compatible with Drupal 8 versions after Drupal 8.8.0 and also Drupal 9 will need an info.yml file like this:

name: My Module
type: module
core_version_requirement: ^8.8 || ^9
meet_bhanvadia’s picture

meet_bhanvadia commented
StatusFileSize
new drupal9_compatibility-3131448-8.patch1.19 KB
new interdiff_6-8.txt276 bytes

@Gaurav_drupal
Made changes and made the patch compatible for d8 and d9.

Please review!!

  • mcdruid committed e0c3333 on 8.x-1.x 
    Issue #3131448 by meet_bhanvadia, voleger, pifagor, Gaurav_drupal:...
mcdruid’s picture

mcdruid commented
Status: Needs review » Fixed

I've manually tested in both D8 (8.9.4-dev) and D9 (9.1.0-dev).

I'll release an RC for D8 shortly, and a full release a few weeks later if there are no problems.

I re-removed core: 8.x as versions of D8 that required that are no longer supported now IIUC.

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.