Just a minor. Composer validate throws a warning.

martin@martin-XPS-13-9370 /var/www/html/d9.localhost/web/modules/contrib/pathauto (8.x-1.x=) $ composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead

Comments

lolandese created an issue. See original summary.

lolandese’s picture

Status: Active » Needs review
StatusFileSize
new521 bytes

After applying the attached patch it is solved:

martin@martin-XPS-13-9370 /var/www/html/d9.localhost/web/modules/contrib/pathauto (8.x-1.x=) $ composer validate
./composer.json is valid

Status: Needs review » Needs work
lolandese’s picture

Priority: Normal » Minor

The test failing is likely another issue, looking at the type of code change.

berdir’s picture

Well, it kind of is, because I tried to be too smart for my own good. I removed the required modules from composer.json, which works as long as it's not changed, but if a patch changes it, it uses that as the source of through and doesn't install them anymore.

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new991 bytes

This should work although I'm considering to just remove that line and let d.o fill it out.

  • Berdir committed 5a5cef0 on 8.x-1.x
    Issue #3131057 by lolandese, Berdir: License "GPL-2.0+" is a deprecated...
berdir’s picture

Status: Needs review » Fixed

Committed.

lolandese’s picture

..removed the required modules from composer.json, which works as long as it's not changed..

Oh, good to know. Thanks for adding this info.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.