Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The HEAD is failing on D9 since #2986452: Database reserved keywords need to be quoted as per the ANSI standard.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | 3129590-17.patch | 4.6 KB | jibran |
| #2 | 8.x-1.x-3129590-2.patch | 2.17 KB | jibran |
Comments
Comment #2
jibranComment #3
jibranComment #4
jibranComment #5
jibran7.4 and 7.3 fails show that triggers are not set up properly.
Comment #6
daffie commentedI have looked at the patch and I see that you are adding the method escapeField() is a couple of places. What the method returns has changed a little bit in that it return the field name with quotes added to the name (for Drupal 9). Maybe something goes wrong when you create the triggers when the field names are quoted?
Comment #7
jibranWe don't need to add the quotes here so I reverted it.
Comment #8
jibranI found the reason for fails.
\Drupal\Core\Database\Connection::quoteIdentifiers()is stripping out the sqaure breckets from the tiggers REGEX.Comment #10
jibranLet's fix some fail for pgsql and sqlite.
Comment #11
jibranLet's try this.
Comment #12
jibranCreated the helper method.
Comment #13
jibranc/p error.
Comment #14
jibranHopefully, this would be it.
Comment #15
jibranhmmm
Comment #16
daffie commented@jibran: Maybe you did not know that: the difference between SQLite and the other 2 databases is that prefixing works a little bit different. SQLite separates the prefix and the table name with a dot.
Comment #17
jibranLet's try this.
Comment #18
jibranHehe, @daffie yeah, I'm trying to figure it out as I go :D
Comment #20
jibranYay!!! green.
Comment #25
jibranThank you @daffie and @chx for the help.