Add core_version_requirement: ^8 || ^9 to auto_menutitle.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#7 Screenshot 2020-04-28 at 8.10.38 PM.png23.35 KBLal_
#5 3128482-5.patch1.01 KBkapilv
#2 3128482-2.patch395 bytesmo_farhaz

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
StatusFileSize
new 3128482-2.patch395 bytes

core version requirement added.

kapilv’s picture

kapilv commented
Issue tags: +Drupal 9 compatibility
ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Status: Needs review » Needs work

Hi @mo_farhaz,

I executed drupal-check and identified the below drupal 9 readiness issues in modules. I feel this should be the scope of current ticket.

Line auto_menutitle.install
------ ----------------------------------------------------
22 Call to deprecated function node_type_get_types():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\node\Entity\NodeType::loadMultiple().
------ ----------------------------------------------------

[ERROR] Found 1 error

kapilv’s picture

kapilv commented
StatusFileSize
new 3128482-5.patch1.01 KB
kapilv’s picture

kapilv commented
Status: Needs work » Needs review
Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new Screenshot 2020-04-28 at 8.10.38 PM.png23.35 KB

Looks good moving the upgrade status passes the module

Lal_’s picture

Lal_
He\Him
commented
Status: Needs review » Reviewed & tested by the community
nehajyoti’s picture

nehajyoti commented

Patch got applied cleanly and issue has been RTBCd, hence committing the patch.

nehajyoti’s picture

nehajyoti commented
Status: Reviewed & tested by the community » Fixed

  • nehajyoti committed 2e58626 on 8.x-1.x 
    Issue #3128482 by mo_farhaz, KapilV, Lal_, ashishdalvi, nehajyoti:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.