When no licence key is enabled the module reports "An error occurred retrieving the sitemorse results, please check your module configuration for errors."

Can you link the "module configuration" text to the configuration page for easy shortcut to setting up.

CommentFileSizeAuthor
#7 link_error_message_to_configuration_page-3124737-7.patch1.56 KBpjnes
#5 link_error_message_to_configuration_page-3124737-5.patch1.62 KBroberto.rivera.ixis
#2 link_error_message_to_configuration_page-3124737-2.patch879 bytespfaocle

Comments

budda created an issue. See original summary.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new link_error_message_to_configuration_page-3124737-2.patch879 bytes

Patch attached for review.

andyrigby’s picture

andyrigby commented

Thanks for your contribution:

-              $('.sitemorse-popup-content').html(Drupal.t("An error occurred retrieving the sitemorse results, please check your module configuration for errors."));
+              $('.sitemorse-popup-content').html(
+                Drupal.t(
+                    "An error occurred retrieving the Sitemorse results, please check your <a href=\"@module-configuration-page\">module configuration</a> for errors.",
+                    {'@module-configuration-page': '/admin/config/content/sitemorse'}

I think we should use the route's URL here, in case it ever changes.

andyrigby’s picture

andyrigby commented
Status: Needs review » Needs work
roberto.rivera.ixis’s picture

roberto.rivera.ixis commented
StatusFileSize
new link_error_message_to_configuration_page-3124737-5.patch1.62 KB

Patch attached for review.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Needs work » Needs review
pjnes’s picture

pjnes commented
StatusFileSize
new link_error_message_to_configuration_page-3124737-7.patch1.56 KB

Patch in #5 works well here, and is now getting the url from the sitemorse_lite.config route.

There was a console.log() introduced in the patch, so have rerolled with that removed.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Assigned: Unassigned » pfaocle
pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Needs review » Fixed

Thanks all! Committed.

  • pfaocle committed 022bf9a on 8.x-1.x authored by PJnes 
    Issue #3124737 by pfaocle, roberto.rivera.ixis, PJnes: Link the error...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.