CommentFileSizeAuthor
#8 3121306-8.patch445 bytesmrinalini9
#2 3121306-2.patch484 bytesNeslee Canil Pinto
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neslee Canil Pinto created an issue. See original summary.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Active » Needs review
FileSize
3121306-2.patch484 bytes

Added configure button. core_version_requirement is added in another issue. just for applying its added here

drugan’s picture

drugan CreditAttribution: drugan as a volunteer commented

Note that just adding the core_version_requirement: ^8 || ^9 to the commerce_marketplace.info.yml file does not fix the Drupal 9 compatibility issue.

Could you please run the drupal-check command in the module's root and fix all errors / warnings in the output of this command...

drugan’s picture

drugan CreditAttribution: drugan as a volunteer commented
Status: Needs review » Needs work
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs work » Needs review

@drugan this patch is not for Drupal 9 compatible, it's only for configuration button in info.yml file

drugan’s picture

drugan CreditAttribution: drugan as a volunteer commented

Okay, can you please to remove the core_version_requirement: ^8 || ^9 entry from the patch...

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented
Status: Needs review » Needs work

no longer applies

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Material for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3121306-8.patch445 bytes

Rerolled patch #2 by addressing #6, please review it.

  • drugan committed 455c5c2 on 8.x-1.x authored by mrinalini9 
    Issue #3121306 by Neslee Canil Pinto, mrinalini9: Configure button in...
drugan’s picture

drugan CreditAttribution: drugan as a volunteer commented
Status: Needs review » Fixed

Thanks everybody!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.