11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ --------------------------------------------------------------
Line src/Controller/AllTableList.php
------ --------------------------------------------------------------
95 Variable $rows in isset() always exists and is not nullable.
------ --------------------------------------------------------------

------ --------------------------------------------------------------
Line src/Controller/TablesViews.php
------ --------------------------------------------------------------
139 Variable $rows in isset() always exists and is not nullable.
------ --------------------------------------------------------------

------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/Form/AddViewsCustomTable.php
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------
105 Variable $databaseOptions might not be defined.
156 Call to deprecated function format_string():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Component\Render\FormattableMarkup instead.
261 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
266 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
278 Return typehint of method Drupal\view_custom_table\Form\AddViewsCustomTable::buildCancelLinkUrl() has invalid type Drupal\view_custom_table\Form\Drupal\Core\Url.
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/Form/EditTableRelations.php
------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------
102 Call to deprecated function format_string():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Component\Render\FormattableMarkup instead.
174 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
179 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
192 Return typehint of method Drupal\view_custom_table\Form\EditTableRelations::buildCancelLinkUrl() has invalid type Drupal\view_custom_table\Form\Drupal\Core\Url.
------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/Form/EditViewsCustomTable.php
------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------
70 Variable $databaseOptions might not be defined.
130 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
135 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
148 Return typehint of method Drupal\view_custom_table\Form\EditViewsCustomTable::buildCancelLinkUrl() has invalid type Drupal\view_custom_table\Form\Drupal\Core\Url.
------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/Form/RemoveViewsCustomTable.php
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
118 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
123 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
134 Return typehint of method Drupal\view_custom_table\Form\RemoveViewsCustomTable::buildCancelLinkUrl() has invalid type Drupal\view_custom_table\Form\Drupal\Core\Url.
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------

------ ---------------------------------------------------
Line src/Plugin/views/field/MysqlDate.php
------ ---------------------------------------------------
178 Variable $custom_format might not be defined.
181 Variable $custom_format might not be defined.
184 Variable $custom_format might not be defined.
187 Variable $custom_format might not be defined.
190 Variable $custom_format might not be defined.
193 Variable $custom_format might not be defined.
196 Variable $custom_format might not be defined.
200 Variable $custom_format might not be defined.
201 Call to deprecated function format_date():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::service('date.formatter')->format().
201 Variable $custom_format might not be defined.
203 Call to deprecated function format_date():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::service('date.formatter')->format().
203 Variable $custom_format might not be defined.
206 Call to deprecated function format_date():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::service('date.formatter')->format().
------ ---------------------------------------------------

------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/views/filter/MysqlDate.php
------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
25 Property Drupal\view_custom_table\Plugin\views\filter\MysqlDate::$time has unknown class Drupal\view_custom_table\Plugin\views\filter\Drupal\Component\Datetime\TimeInterface as its type.
33 Property Drupal\view_custom_table\Plugin\views\filter\MysqlDate::$dateFormatter has unknown class Drupal\view_custom_table\Plugin\views\filter\Drupal\Core\Datetime\DateFormatterInterface as its
type.
------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------ --------------------------------------------------------------
Line view_custom_table.module
------ --------------------------------------------------------------
200 Undefined variable: $related_table_pri_key
217 Variable $data in isset() always exists and is not nullable.
------ --------------------------------------------------------------

[ERROR] Found 35 errors

CommentFileSizeAuthor
#15 drupal-9-compatibility-3115789-15.patch12.85 KBbladedu
#14 interdiff_9-14.txt734 bytesdca123
#14 drupal-9-compatibility-3115789-14.patch13.68 KBdca123
#9 interdiff-6-9.txt1.09 KBnaresh_bavaskar
#9 3115789-9.patch13.09 KBnaresh_bavaskar
#8 Screenshot 2020-03-20 at 11.54.20 AM.png89.58 KBnaresh_bavaskar
#3 drupal_9_compatibility-3115789-3.patch11.97 KBsiddhant.bhosale
#6 drupal_9_compatibility-3115789-6.patch12.08 KBsiddhant.bhosale
#6 interdiff_3-6.txt1.59 KBsiddhant.bhosale

Issue fork view_custom_table-3115789

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

siddhant.bhosale created an issue. See original summary.

siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: Unassigned » siddhant.bhosale
siddhant.bhosale’s picture

siddhant.bhosale commented
StatusFileSize
new drupal_9_compatibility-3115789-3.patch11.97 KB

Hi, I have fixed all the issues from the Drupal 9 Compatibility report.
Please review.

siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: siddhant.bhosale » Unassigned
Status: Active » Needs review
siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: Unassigned » siddhant.bhosale
Status: Needs review » Needs work
siddhant.bhosale’s picture

siddhant.bhosale commented
StatusFileSize
new interdiff_3-6.txt1.59 KB
new drupal_9_compatibility-3115789-6.patch12.08 KB

Hi,
I have missed one scenario in the where "Base table or view not found" if we have a prefix for tables.
So adding the new patch and interdiff as well.

siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: siddhant.bhosale » Unassigned
Status: Needs work » Needs review
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
Status: Needs review » Needs work
StatusFileSize
new Screenshot 2020-03-20 at 11.54.20 AM.png89.58 KB

stil minor Compatibility work need to fix......Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3115789-9.patch13.09 KB
new interdiff-6-9.txt1.09 KB

Please review

kapilv’s picture

kapilv commented
Issue tags: +Drupal 9 compatibility
ggh’s picture

ggh commented

When can we expect a stable release for this module ported for Drupal 9,Can we have some timelines

dca123’s picture

dca123 commented

#9 fails

Running drupal-check:

 ------ ------------------------------------------------------------------
  Line   src/Plugin/views/field/MysqlDate.php
 ------ ------------------------------------------------------------------
  65     Call to deprecated method getStorage() of class
         Drupal\Core\Entity\EntityManager:
         in drupal:8.0.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Entity\EntityTypeManagerInterface::getStorage()
         instead.
 ------ ------------------------------------------------------------------

 [ERROR] Found 1 error
dca123’s picture

dca123 commented

In /src/Plugin/views/field/MysqlDate.php

I replaced line 5

use Drupal\Core\Entity\EntityStorageInterface;

with

use Drupal\Core\Entity\EntityTypeManagerInterface;

I replaced line 65

$container->get('entity.manager')->getStorage('date_format')

with

\Drupal::entityTypeManager()->getStorage('date_format')

 11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

I'm working on a patch but I'm not familiar with Drupal patching and interdiffs. If someone wants to patch they can. In the meantime I'll work on the patch.

dca123’s picture

dca123 commented
StatusFileSize
new drupal-9-compatibility-3115789-14.patch13.68 KB
new interdiff_9-14.txt734 bytes

Here is the patch and interdiff

bladedu’s picture

bladedu
he/him
Primary language Italian
Location Italy
commented
StatusFileSize
new drupal-9-compatibility-3115789-15.patch12.85 KB

reworked patch #14 and added core_version_requirement: ^8 || ^9 in the .info.yaml file.

smustgrave’s picture

smustgrave commented

Is there any issue with using this for Drupal 9?

coaston’s picture

coaston commented

Hi,

I used attached patch, no issue found, but when I create view in database and want to load it here, I can add it to tables, but unable to see it in views, is that normal ? (The reason why I created sql view is due to calculation, now need to load it back to views in Drupal)

anoopjohn made their first commit to this issue’s fork.

anoopjohn’s picture

anoopjohn commented

Any ETA on the Drupal 9 version of the module? I am have created a fork for this issue and have applied the patch in the fork. Am going to test this in a site I am working on migrating from D8 to D9

https://git.drupalcode.org/issue/view_custom_table-3115789

anoopjohn opened merge request !3

smustgrave’s picture

smustgrave commented

Also been using this on a D9 site but had to checkin the module since composer wouldn't even download it to try and patch it :(

Ahmed_Samir made their first commit to this issue’s fork.

cmcintosh’s picture

cmcintosh commented

Created a public repo for the drupal 9 compatibility. If you need to add it to your project you can follow: https://www.daggerhartlab.com/composer-how-to-use-git-repositories/ for public repos on github. https://github.com/WembassyCo/views_custom_table is the url for the work i am maintaining. Minimally

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

ok that's it, someone needs to take over ownership of this module, and FAST

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

for those that can't wait, use this:

composer require 'drupal/view_custom_table:9.0.x-dev@dev'

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3232266: Offering to maintain Views Custom Table

  • joseph.olstad committed 5ba8e8e on 8.x-1.x authored by Bladedu 
    Issue #3115789 by siddhant.bhosale, naresh_bavaskar, dca123, Bladedu,...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

release to follow shortly

cmcintosh’s picture

cmcintosh commented

Thanks for the work I will be reviewing and merging soon.

cmcintosh’s picture

cmcintosh commented

sorry disregard, im unable to merge

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

a release to follow shortly, working on it

  • joseph.olstad committed 5ba8e8e on 9.0.x authored by Bladedu 
    Issue #3115789 by siddhant.bhosale, naresh_bavaskar, dca123, Bladedu,...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

New release for Drupal 8, Drupal 9

Use composer to get it:

composer require 'drupal/view_custom_table:^1.6'

OR

download version 8.x-1.6

Also a new release for Drupal 7 , version 7.x-1.0

download version 7.x-1.0

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Fixed » Closed (fixed)