With official support for composer, is it necessary to update composer.json with the right core dependency?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3114221-remove-composer-require-87.patch | 982 bytes | dave reid |
| #4 | 3114221-4.patch | 565 bytes | dsdeiz |
| #2 | 3114221-1.patch | 349 bytes | dsdeiz |
Comments
Comment #2
dsdeiz commentedComment #3
dave reidWe should likely get rid of the composer.json file and just rely on using Drupal.org's packagist to generate it for us, since we don't actually need any custom dependencies.
Comment #4
dsdeiz commentedOh okay, I guess that's how Drupal.org works for packages. Anyway, yeah, I experience this with a drupal-composer/drupal-project running ~8.6 and
composer update drupal/embedseemed to have updated embed to the latest version despite the latest version requiring drupal:system >= 8.7.Patch attached.
Comment #5
dave reidThis also updates the core_version_requirement for the module to be Drupal 9 compatible.
Comment #7
dave reidComment #9
dave reidCommitted #5 to 8.x-1.x because removing a composer.json file will always fail tests until the next release. I will be making an 8.x-1.4 release shortly which should help resolve everything.
Comment #10
dave reidComment #11
dave reid