With official support for composer, is it necessary to update composer.json with the right core dependency?

Comments

dsdeiz created an issue. See original summary.

dsdeiz’s picture

Status: Active » Needs review
StatusFileSize
new349 bytes
dave reid’s picture

We should likely get rid of the composer.json file and just rely on using Drupal.org's packagist to generate it for us, since we don't actually need any custom dependencies.

dsdeiz’s picture

StatusFileSize
new565 bytes

Oh okay, I guess that's how Drupal.org works for packages. Anyway, yeah, I experience this with a drupal-composer/drupal-project running ~8.6 and composer update drupal/embed seemed to have updated embed to the latest version despite the latest version requiring drupal:system >= 8.7.

Patch attached.

dave reid’s picture

StatusFileSize
new982 bytes

This also updates the core_version_requirement for the module to be Drupal 9 compatible.

dave reid’s picture

  • Dave Reid committed 2c47f34 on 8.x-1.x
    Issue #3114221 by dsdeiz, Dave Reid, lolandese: Require Drupal 8.7.7+...
dave reid’s picture

Committed #5 to 8.x-1.x because removing a composer.json file will always fail tests until the next release. I will be making an 8.x-1.4 release shortly which should help resolve everything.

dave reid’s picture

Status: Needs review » Fixed
dave reid’s picture

Title: Include dependency in composer.json » Update core_version_requirement and remove composer.json

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.