Problem/Motivation
The module is not compatible with Drupal 9
Proposed resolution
Fix Drupal 9 compatibility errors
Remaining tasks
Fix errors
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
Drupal 9 compatibility.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-3108845-3-6.txt | 872 bytes | scott_euser |
| #6 | role_delegation-drupal-9-compatibility-3108845-6.patch | 2.13 KB | scott_euser |
| #3 | interdiff-3108845-2-3.txt | 905 bytes | scott_euser |
| #3 | role_delegation-drupal-9-compatibility-3108845-3.patch | 2.13 KB | scott_euser |
| #2 | role_delegation-drupal-9-compatibility-3108845-2.patch | 1.01 KB | scott_euser |
Comments
Comment #2
scott_euser commentedA couple small fixes:
Comment #3
scott_euser commentedUpdated tests now as well with Drupal 9 compatibility, setting the default theme for browser tests.
Comment #4
gambryLooks good to me @scott_euser . As `core: 8.x` in info.yml file still allows to install this on version prior 8.7.7 I was wondering if the `$defaultTheme` variable could cause any issue in there, but I believe that change will be just ignored and so all good. RTBC.
Comment #5
jungleAdding
protected $defaultTheme = 'classy';is the quickiest way to fix warnings without update assertions. But it might be good to change it to stark or stable. Or out of this issue's scope?Comment #6
scott_euser commentedYes I think $defaultTheme does nothing, just checking in the contribute slack channel.
Updated to use stark, there is no reliance on markup for these tests so tests should pass as is.
Comment #7
scott_euser commentedConfirmed by andypost via Slack that defaultTheme will be ignored as you suspected in #4
Comment #8
gambryYep, the change makes sense.
Comment #9
jeroentClosed #3068107: Replace usage of entity.manager with entity_type.manager in Drupal\role_delegation\Plugin\views\field\RoleDelegationUserBulkForm as a duplicate.
Comment #10
jeroentComment #12
jeroentCommitted and pushed to 8.x-1.x. Thanks!
Comment #13
scott_euser commentedGreat, thanks!