Problem/Motivation

https://dev.acquia.com/drupal9/deprecation_status/errors?project=workben... reports the following:

Call to deprecated method getLatestRevision() of class Drupal​\​content_moderation​\​ModerationInformationInterface. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use RevisionableStorageInterface::getLatestRevisionId and RevisionableStorageInterface::loadRevision instead.

Proposed resolution

Fix the remaining deprecations and prepare the module for Drupal 9.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3108603-2.patch5.69 KBmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Status: Active » Needs review
StatusFileSize
new 3108603-2.patch5.69 KB

This should fix the message from the issue summary. Let's see the tests.

mbovan’s picture

mbovan commented
Issue tags: +ContributionWeekend2020, +ContributionWeekendCH
mbovan’s picture

mbovan commented
Issue tags: +Drupal 9 compatibility
pminf’s picture

pminf
Primary language German
Location Nuremburg (Germany), formerly Dresden
commented
Status: Needs review » Reviewed & tested by the community

Changes are OK and plausible. Drupals update check doesn't show any errors and email notification is still working.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Category: Feature request » Task

Looking at that message, you'd think we can't do the change to

Call to deprecated method getLatestRevision() of class Drupal​\​content_moderation​\​ModerationInformationInterface. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use RevisionableStorageInterface::getLatestRevisionId and RevisionableStorageInterface::loadRevision instead.

Until 8.7.x is EOL, which is not until 8.9.x comes out - because it reference 8.8.0 - but it seems that method came in around 8.5.0 according to git logs

(7f00c34194bf3c71a4de22823960a5d20f55ed5a)

So queuing an 8.7 test for this patch

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

  • larowlan committed 10babc3 on 8.x-1.x authored by mbovan 
    Issue #3108603 by mbovan, larowlan, pminf: Prepare module for Drupal 9
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Rolled https://www.drupal.org/project/workbench_email/releases/8.x-1.4

The one where mbovan added D9 support 😎

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.