When using PHP 7.3, throws the following notice and doesn't match IDs.
Warning: preg_match(): Compilation failed: invalid range in character class at offset 38 in Drupal\video_embed_facebook\Plugin\video_embed_field\Provider\Facebook::getIdFromInput() (line 46 of /var/www/docroot/modules/contrib/video_embed_facebook/src/Plugin/video_embed_field/Provider/Facebook.php)

This is because hyphen (-) should be escaped in the regexp.

CommentFileSizeAuthor
#3 video_embed_facebook_PHP7.3_preg_match-3108537-3.patch725 bytesclement.ferrier

Comments

clement.ferrier created an issue. See original summary.

clement.ferrier’s picture

clement.ferrier commented
Issue summary: View changes
clement.ferrier’s picture

clement.ferrier commented
StatusFileSize
new video_embed_facebook_PHP7.3_preg_match-3108537-3.patch725 bytes
clement.ferrier’s picture

clement.ferrier commented
Status: Active » Needs review
ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

I can confirm that this patch makes the warning go away and facebook video embeding still works ;)

Also, this is backwards compatible, here a nice explanation: https://stackoverflow.com/a/56551371

govind.maloo’s picture

govind.maloo commented

@clement.ferrier Thanks for the heads up. Patch apply clean and fixed the issue.

sam152’s picture

sam152 commented
Status: Reviewed & tested by the community » Fixed

sam152’s picture

sam152 commented

https://www.drupal.org/project/video_embed_facebook/releases/8.x-1.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.