Review of the 8.x-1.x branch (commit b522584):

Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.
The hide_preview.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...upal/pareviewsh/pareview_temp/src/tests/src/Unit/HidePreviewTest.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
11 | ERROR | [x] Tag value indented incorrectly; expected 1 space but
| | found 3
58 | ERROR | [x] Expected 1 blank line after function; 0 found
59 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/HidePreviewConfigForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
137 | ERROR | [x] Expected 1 blank line after function; 0 found
138 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 552ms; Memory: 4Mb

CommentFileSizeAuthor
#3 hide_preview-3107914-interdiff-2-3.txt1.74 KBWebbeh
#3 hide_preview-3107914-3.patch2.56 KBWebbeh
#2 issue_fix-3107914-2.patch1.98 KBankush_03

Issue fork hide_preview-3107914

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ankushgautam76@gmail.com created an issue. See original summary.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Category: Task » Bug report
Status: Needs work » Needs review
StatusFileSize
new issue_fix-3107914-2.patch1.98 KB
Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Title: Maintain drupal Coding Standarad » PAReview.sh recommended fixes
StatusFileSize
new hide_preview-3107914-3.patch2.56 KB
new hide_preview-3107914-interdiff-2-3.txt1.74 KB

@ankushgautam76@gmail.com, your changes introduced some issues into the README. Adjusting - for review.

Removed the "No" under requirements and added more appropriate copy.

Converted CONFIGURATION into a numbered list.

Removed CUSTOMIZATIONS.

timothee.moulin’s picture

timothee.moulin commented
Category: Bug report » Task

timothee.moulin opened merge request !5

  • timothee.moulin committed 4002730 on 8.x-1.x 
    fix PAReview.sh #3107914
apply patch from @ankushgautam76gmailcom 
apply...
timothee.moulin’s picture

timothee.moulin commented

Your patches have been applied

thanks

timothee.moulin’s picture

timothee.moulin commented
Status: Needs review » Fixed
timothee.moulin’s picture

timothee.moulin commented
Status: Fixed » Closed (fixed)