Well, There are some minor adjustments that can be made about routing: styles, names and routes. Something more refined that approaches the standards of Drupal.
Due to they are small adjustments of the same nature and context, they can go in the same patch, doing some changes in humanstxt.routing.yml and humans.info.yml:
1- Change name of the main route replacing it with some more shorter.
2- Move the config path to a more related place, like "development".
3- Rename the Config Form adjusting the Class Name.
4- Change the configure path using the route name instead of the pure path.
In a complementary way, change also the link info in links.menu.yml file:
route_name: humanstxt_admin_settings
parent: system.admin_config_search
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff_4_5.txt | 205 bytes | davidjguru |
#5 | small-adjustments-in-routing-3102492-5.patch | 1.68 KB | davidjguru |
#4 | small-adjustments-in-routing-3102492-4.patch | 1.68 KB | davidjguru |
davidjguru_humans_txt_drupal_8_adjusting_routing.png | 43.85 KB | davidjguru |
Comments
Comment #2
davidjguruComment #3
davidjguruComment #4
davidjguruInclude changes in:
- humanstxt.routing.yml
- humanstxt.info.yml
- humanstxt.permissions.yml
- humanstxt.links.menu.yml
Comment #5
davidjguruI discovered a backslash that I forgot to add in the previous patch, so I uploaded an updated version and an little interdiff to show only the small change between patches.
Comment #7
pcambraVery nice! thanks