Well, There are some minor adjustments that can be made about routing: styles, names and routes. Something more refined that approaches the standards of Drupal.

Due to they are small adjustments of the same nature and context, they can go in the same patch, doing some changes in humanstxt.routing.yml and humans.info.yml:

1- Change name of the main route replacing it with some more shorter.

2- Move the config path to a more related place, like "development".

3- Rename the Config Form adjusting the Class Name.

4- Change the configure path using the route name instead of the pure path.

Changes in routing and info file

In a complementary way, change also the link info in links.menu.yml file:

route_name: humanstxt_admin_settings
parent: system.admin_config_search

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davidjguru created an issue. See original summary.

davidjguru’s picture

Issue summary: View changes
davidjguru’s picture

davidjguru’s picture

Status: Active » Needs review
FileSize
1.68 KB

Include changes in:

- humanstxt.routing.yml
- humanstxt.info.yml
- humanstxt.permissions.yml
- humanstxt.links.menu.yml

davidjguru’s picture

I discovered a backslash that I forgot to add in the previous patch, so I uploaded an updated version and an little interdiff to show only the small change between patches.

  • pcambra committed 0fbd0c4 on 8.x-1.x authored by davidjguru
    Issue #3102492 by davidjguru: Make some small adjustments in Routing
    
pcambra’s picture

Status: Needs review » Fixed

Very nice! thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.