Problem/Motivation

After to run drupal-check from this version 8.x-1.x-dev displayed the next errors:

Besides, over the version 8.x-2.x-dev doesn't work.

drupal-check video
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 42 MB of memory.

To avoid this issue, allow to use more memory with the --memory-limit option.
 30/30 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldFormatter/VideoEmbedPlayerFormatter.php         
 ------ ---------------------------------------------------------------------- 
  45     Call to deprecated function file_uri_scheme():                        
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                 
         Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::getScheme()  
         instead.                                                              
  158    Call to deprecated function entity_get_form_display():                
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                 
         EntityDisplayRepositoryInterface::getFormDisplay() instead.           
 ------ ---------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldFormatter/VideoEmbedThumbnailFormatter.php                  
 ------ ---------------------------------------------------------------------------------- 
  52     Call to deprecated function entity_get_form_display():                            
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                             
         EntityDisplayRepositoryInterface::getFormDisplay() instead.                       
  59     Call to deprecated function file_uri_scheme():                                    
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                             
         Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::getScheme()              
         instead.                                                                          
  63     Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface:  
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                 
         Use \Drupal\Core\Entity\EntityInterface::toUrl() instead.                         
  165    Call to deprecated function entity_get_form_display():                            
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                             
         EntityDisplayRepositoryInterface::getFormDisplay() instead.                       
 ------ ---------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldFormatter/VideoPlayerFormatter.php     
 ------ ------------------------------------------------------------- 
  190    Call to deprecated function entity_get_form_display():       
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use        
         EntityDisplayRepositoryInterface::getFormDisplay() instead.  
 ------ ------------------------------------------------------------- 

 ------ -------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldFormatter/VideoPlayerListFormatter.php  
 ------ -------------------------------------------------------------- 
  65     Call to deprecated function entity_get_form_display():        
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use         
         EntityDisplayRepositoryInterface::getFormDisplay() instead.   
 ------ -------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldType/VideoItem.php                                  
 ------ -------------------------------------------------------------------------- 
  158    Call to deprecated function file_prepare_directory():                     
         in drupal:8.7.0 and is removed from drupal:9.0.0.                         
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().            
  185    Call to deprecated method entityManager() of class Drupal:                
         in drupal:8.0.0 and is removed from drupal:9.0.0.                         
         Use \Drupal::entityTypeManager() instead in most cases. If the needed     
         method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the  
         deprecated \Drupal\Core\Entity\EntityManager to find the                  
         correct interface or service.                                             
 ------ -------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/VideoEmbedWidget.php                         
 ------ -------------------------------------------------------------------------- 
  393    Call to deprecated method entityManager() of class Drupal:                
         in drupal:8.0.0 and is removed from drupal:9.0.0.                         
         Use \Drupal::entityTypeManager() instead in most cases. If the needed     
         method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the  
         deprecated \Drupal\Core\Entity\EntityManager to find the                  
         correct interface or service.                                             
 ------ -------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------ 
  Line   src/Plugin/Field/FieldWidget/VideoUploadWidget.php                      
 ------ ------------------------------------------------------------------------ 
  75     Call to deprecated function file_upload_max_size():                     
         in drupal:8.7.0 and is removed from drupal:9.0.0.                       
         Use \Drupal\Component\Utility\Environment::getUploadMaxSize() instead.  
  254    Call to deprecated function file_upload_max_size():                     
         in drupal:8.7.0 and is removed from drupal:9.0.0.                       
         Use \Drupal\Component\Utility\Environment::getUploadMaxSize() instead.  
 ------ ------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------- 
  Line   src/Plugin/migrate/cckfield/VideoItem.php                                      
 ------ ------------------------------------------------------------------------------- 
  14     Class Drupal\video\Plugin\migrate\cckfield\VideoItem extends deprecated class  
         Drupal\migrate_drupal\Plugin\migrate\cckfield\CckFieldPluginBase:              
         in drupal:8.4.0 and is removed from drupal:9.0.0. Use                          
         \Drupal\migrate_drupal\Plugin\migrate\field\FieldPluginBase instead.           
 ------ ------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------- 
  Line   src/ProviderPluginBase.php                                      
 ------ ---------------------------------------------------------------- 
  124    Call to deprecated function file_prepare_directory():           
         in drupal:8.7.0 and is removed from drupal:9.0.0.               
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().  
  128    Call to deprecated function file_unmanaged_save_data():         
         in drupal:8.7.0 and is removed from drupal:9.0.0.               
         Use \Drupal\Core\File\FileSystemInterface::saveData().          
 ------ ---------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/StreamWrapper/VideoRemoteStreamWrapper.php     
 ------ --------------------------------------------------- 
  124    Call to deprecated function drupal_basename():     
         in drupal:8.0.0 and is removed from drupal:9.0.0.  
         Use \Drupal\Core\File\FileSystem::basename().      
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/VideoItemSerializationTest.php                                               
 ------ ---------------------------------------------------------------------------------------------- 
  65     Call to deprecated method setExpectedException() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                             
         Backward compatibility for PHPUnit 4 will no longer be supported.                             
 ------ ---------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 18 errors

Thank's

CommentFileSizeAuthor
#8 drupal_9_deprecated_code_report-3101969-8.patch6.14 KBmrinalini9
#6 drupal_9_deprecated_code_report-3101969-5.patch12.28 KBfrocha
#4 3101969-4.patch21.22 KBSudeepthi Peteti
#4 applyingpatch2.JPG29.72 KBSudeepthi Peteti
#3 drupal_9_deprecated_code_report-3101969-2.patch19.65 KBgnanagowthaman sankar

Issue fork video-3101969

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gmangones created an issue. See original summary.

gnanagowthaman sankar’s picture

gnanagowthaman sankar commented

Hi @gmangones,

Here by i attached the patch. Please review and let me know for changes.

Thanks & Regards,
Gnanagowthaman sankar

gnanagowthaman sankar’s picture

gnanagowthaman sankar commented
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated_code_report-3101969-2.patch19.65 KB

Patch

Thanks & Regards,
Gnanagowthaman sankar

Sudeepthi Peteti’s picture

Sudeepthi Peteti commented
StatusFileSize
new applyingpatch2.JPG29.72 KB
new 3101969-4.patch21.22 KB

Hi,
The above patch in comment #2 has some errors. The patch is not applying. Attached image for it.
Removed all deprecated code and created a patch.
Please review.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

I increase the version up to 8.x-2.x (dev).

frocha’s picture

frocha commented
StatusFileSize
new drupal_9_deprecated_code_report-3101969-5.patch12.28 KB

I created a patch to adapt this module for Drupal 9.3.9

Update: ignore this patch

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work

Patch is failed, please reroll

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated_code_report-3101969-8.patch6.14 KB

Rerolled patch #6, please review it.

podarok opened merge request !7

  • podarok committed 509ea48 on 3.0.x 
    Issue #3101969 by Sudeepthi Peteti, podarok, mrinalini9: Drupal 9...
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 8.x-2.x-dev » 3.0.x-dev
Status: Needs review » Fixed
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 3.0.x-dev » 3.0.2
Status: Fixed » Closed (fixed)

Thanks
Tagged in release

B1’s picture

B1 commented

I see the issue status has been Closed (fixed), but thought it would be worthwhile to note:

Summary:
In my particular case when I installed video:^3.0 it caused a White Screen of Death, had to revert Video Module version.

Details:

Drupal 9.4.5
PHP Version 8.1.7

composer require 'drupal/video:^3.0'

WSOD

drush ws:

23480 27/Aug 12:56 php Error Drupal\Core\Extension\InfoParserException: The 'core_version_requirement'
constraint (^9 || ^10) requires the 'core' key not be set in
modules/contrib/video/video.info.yml in Drupal\Core\E

composer require 'drupal/video:^1.5@alpha'

Problem solved (no WSOD)

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 3.0.2 » 3.0.3

Whoops
Corrected https://www.drupal.org/project/video/releases/3.0.3