Prepare views_infinite_scroll module for Drupal 9

#4 looks good to me.

➜  d9 git:(8.8.x) ✗ ./vendor/mglaman/drupal-check/drupal-check --drupal-root=./ modules/contrib/views_infinite_scroll

 5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

global $pager_page_array, $pager_total are deprecated and should be replaced by PageManager service methods.

Fixing the typo in title.

Adding doc comment for variable.

/**
   * {@inheritdoc}
   */
  protected $defaultTheme = 'classy';

global $pager_page_array, $pager_total are deprecated and should be replaced by PageManager service methods.

Yes, needs work for that.

Haven't yet addressed #11, but this merges in the changes from #3116546: Declare Drupal 9 compatibility, as suggested by @Berdir in that issue.

Converted the simpletest, and I think this addresses #11.

+++ b/views_infinite_scroll.info.yml
@@ -3,6 +3,7 @@ type: module
 package: Views
 core: 8.x
+core_version_requirement: ^8 || ^9
 

the pager deprecation changes means this needs ^8.8 || ^9 and with that, removal of the core: 8.x key.

As mentioned on slack, I didn't check if the pager updates are correct, but the fact that the tests pass on 8.8 is already a good indicator, still, a manual test against D9 would be great as extra proof.

+++ b/views_infinite_scroll.info.yml
@@ -3,6 +3,7 @@ type: module
 core: 8.x
+core_version_requirement: ^8 || ^9

core part should be removed and pager require core_version_requirement: ^8.8 || ^9

Fixed core_version_requirement key.

I tested this manually on D9, and found that it actually errors in D8.8 and D9 if items per page is set to zero, even though it still allows the D8.8 test to pass. Attempting to address that here.

I paired with @katherined on this. The patch in #18 is very close to what it needs to be -- I just wanted to understand some of the pager logic happening in the preprocess function, and the nature of the additional test coverage. Now that I do (thanks @katherined!) I removed a few extraneous changes in IntegrationSmokeTest, expanded the comment over the new coverage in InfiniteScrollTest, and slightly cleaned up the changes to the preprocess function, with a FAIL patch to prove that the isset($pager) check in the preprocess function is actually effectively covered by InfiniteScrollTest. So really, just minor stuff! This is a good patch, it should be committed. :)

Whoops, I screwed up with git and botched that patch. Here is the correct pair.

Done, thanks!

there is still an error "pager_query_add_page()"

Error: Call to undefined function pager_query_add_page() in views_infinite_scroll_preprocess_views_view() (line 55 of /var/www/html/docroot/modules/contrib/views_infinite_scroll/views_infinite_scroll.module)

Attached is the patch to solve

Error: Call to undefined function pager_query_add_page() in views_infinite_scroll_preprocess_views_view() (line 55 of /var/www/html/docroot/modules/contrib/views_infinite_scroll/views_infinite_scroll.module)

Attached is the patch to solve

Error: Call to undefined function pager_query_add_page() in views_infinite_scroll_preprocess_views_view() (line 55 of /var/www/html/docroot/modules/contrib/views_infinite_scroll/views_infinite_scroll.module)

I suggest you create a new issue for that, might get lost here and only maintainers could reopen it. Then reference it here.