php drupal-check.phar modules/contrib/workbench_email/
 36/36 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Form/TemplateForm.php                                                         
 ------ ---------------------------------------------------------------------------------- 
  280    Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface.  
 ------ ---------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/RecipientTypeInterface.php                                                                                                             
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  23     Interface Drupal\workbench_email\Plugin\RecipientTypeInterface extends deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface.  
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 2 errors
CommentFileSizeAuthor
#4 deprecated-3094338-4.patch1.61 KBsergiu stici
#2 deprecated-3094338-2.patch1.62 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3094338-2.patch1.62 KB

Here's the patch, please review.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +DrupalSouth 2019 
+++ b/src/Form/TemplateForm.php
@@ -277,7 +277,7 @@ class TemplateForm extends EntityForm {
+    $form_state->setRedirectUrl($workbench_email_template->toUrl('collection')->toString());

can you remove the ->toString() here which will fix the test fail.

Can you repost the output of drupal-check after applying this patch?

Thanks!

sergiu stici’s picture

sergiu stici commented
StatusFileSize
new deprecated-3094338-4.patch1.61 KB 
php drupal-check.phar modules/contrib/workbench_email/
 36/36 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] No errors

Here is a new patch. I removed ->toString().

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

🎉
Thanks

Cutting a new release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.