Use dependency injection instead of \Drupal:: global object

Are you still working on this issue?
If not, I would like to take up this issue.

I will work on this.

Fixed all the drupal calls and coding standards in their respective files

Will review this.

While testing this patch, this following error occurred.

[php7:error] [pid 1335] [client ::1:51754] PHP Fatal error:  Declaration of Drupal\\paragraphs\\Plugin\\Field\\FieldWidget\\ParagraphsWidget::create(Symfony\\Component\\DependencyInjection\\ContainerInterface $container) must be compatible with Drupal\\Core\\Field\\WidgetBase::create(Symfony\\Component\\DependencyInjection\\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) in /var/www/html/drupalDemo/web/modules/contrib/paragraphs/src/Plugin/Field/FieldWidget/ParagraphsWidget.php on line 273, referer: http://localhost/drupalDemo/web/admin/structure/types/manage/test/fields/add-field

The create method of the ParagraphsWidget Class is not compatible with the core's WidgetBase Class.

Steps to Reproduce

1. Create a paragraph type, by going to admin/structure/paragraphs_type .
2. Add a text or any field to the newly created paragraph type.
3. After the paragraph type is created, Add the paragraph field to a content type.
4. Then, while accessing the field widget of the paragraph type, a HTTP 500 response is displayed.

Also, I think the dependency injection in the ParagraphsWidget is not handled properly.

Patch is outdated.

I have run the grep command. Here are the new files with \\Drupal::

./src/ParagraphAccessControlHandler.php
./src/MigrationPluginsAlterer.php
./src/Plugin/migrate/D7ParagraphsItemDeriver.php
./src/Plugin/migrate/D7FieldCollectionItemDeriver.php
./src/Plugin/Field/FieldFormatter/ParagraphsSummaryFormatter.php
./src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
./src/Plugin/Field/FieldWidget/ParagraphsWidget.php
./src/Entity/ParagraphsType.php
./src/Entity/Paragraph.php
./modules/paragraphs_library/src/Entity/LibraryItem.php

Patch in progress.

Here is the patch.

Some files stil contains \Drupal:: calls :

• ./src/Plugin/Field/FieldFormatter/ParagraphsSummaryFormatter.php : Service call in static functions
• ./src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php : Service call in static functions
• ./src/Plugin/Field/FieldWidget/ParagraphsWidget.php : Service call in static functions
• ./src/Entity/ParagraphsType.php : Not possible to user container for Dependency Injection on Entities
• ./src/Entity/Paragraph.php : Not possible to user container for Dependency Injection on Entities
• ./modules/paragraphs_library/src/Entity/LibraryItem.php : Not possible to user container for Dependency Injection on Entities

I'll review this!

The patch #14 I found a few standard coding problems in the added code and, when I ran the tests, I got a lot of errors that weren't there before the patch, so I'm moving to needs work

Hi @tmaiochi, can you give me more details .
When I run phpcs checks I have the following results :

• bash-5.1# ../vendor/bin/phpcs --standard=Drupal modules/contrib/paragraphs/src/ParagraphAccessControlHandler.php
• bash-5.1# ../vendor/bin/phpcs --standard=Drupal modules/contrib/paragraphs/src/Plugin/migrate/D7*

for files that have issues on phpcs :
Before patch :

FILE: /var/www/web/modules/contrib/paragraphs/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
--------------------------------------------------------------------------------------------------------
FOUND 113 ERRORS AND 15 WARNINGS AFFECTING 122 LINES
--------------------------------------------------------------------------------------------------------
   84 | ERROR   | [x] Short array syntax must be used to define arrays

FILE: /var/www/web/modules/contrib/paragraphs/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
--------------------------------------------------------------------------------------------------------
FOUND 88 ERRORS AND 20 WARNINGS AFFECTING 102 LINES
--------------------------------------------------------------------------------------------------------
  112 | ERROR   | [x] Expected 1 space after IF keyword; 0 found

After patch :

FILE: /var/www/web/modules/contrib/paragraphs/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
--------------------------------------------------------------------------------------------------------
FOUND 113 ERRORS AND 15 WARNINGS AFFECTING 122 LINES
--------------------------------------------------------------------------------------------------------
  214 | ERROR   | [x] Short array syntax must be used to define arrays

FILE: /var/www/web/modules/contrib/paragraphs/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
--------------------------------------------------------------------------------------------------------
FOUND 88 ERRORS AND 20 WARNINGS AFFECTING 102 LINES
--------------------------------------------------------------------------------------------------------
  240 | ERROR   | [x] Expected 1 space after IF keyword; 0 found

Of course @julien_g

In reality it's just a phpcs error that accuses the InlineParagraphsWidget.php file:

I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php

And the only line that there was a change and phpcs gives a message was this:

396 | ERROR | [x] Short array syntax must be used to define arrays

Thanks @tmaiochi,

here is the patch with phpcs error fixed

I will review this

Steps performed:
1 - downloaded the module and applied the patch from #19
2 - ran phpcs to properly review the dependency injections
3 - opened an MR and committed the changes from #19

Moving to RTBC.

I do suggest phpcs should be created on another issue if none exists.
My opinion: This issue should address the issue scope which is dependency injections as described by the title.

Hi,

New patch with failed test fixes.

Service not found exception on test fixes.

Here is the patch that pass all tests

I'm going to review this!

Steps performed:
1 - downloaded the module and applied the patch from #31.
2 - ran phpcs to properly review the dependency injections.

Moving to RTBC.

Must be a merge request now.

#3091424: Created and rebase the MR with respect to 8.x-1.x.
Moving to Needs Review.