Drupal 9 Deprecated Code Report

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Block Token 8.x-1.0-alpha1+1-dev
Scanned on Sat, 06/20/2020 - 11:43.

1 error found. 1 warnings found.

C:\xampp\htdocs\d\drupal9\app\modules\contrib\block_token\src\BlockToke
nPermissions.php:
┌─────────┬──────┬─────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├─────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Fix now │ 28 │ Parameter $entity_manager of method │
│ │ │ Drupal\block_token\BlockTokenPermissions::__construct() has │
│ │ │ typehint with deprecated interface │
│ │ │ Drupal\Core\Entity\EntityManagerInterface. Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:9.0.0. │
│ │ │ │
└─────────┴──────┴─────────────────────────────────────────────────────────────┘

modules/contrib/block_token/block_token.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Add core_version_requirement: ^8 || ^9 to │
│ manually │ │ modules/contrib/block_token/block_token.info.yml to │
│ │ │ designate that the module is compatible with Drupal 9. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │

Updated patch. Please review !!

Patch #5 looks good.

Any chance we can get this committed? Or does anyone know a way around composer not wanting to pull this down?

I also need this committed so I can go to D9.

Thanks

Ditto to #8. Can we get this committed?

@bestller, Using this branch, I'm getting an error regarding the lack of composer.json file. Can I be given write access to this repo/branch or have you add a composer.json to that merge request please?

Disregard, I gained access and pushed the changes to your existing fork.

Additional changes were required to make this module work properly. New Merge Request created and pushing this up to "Major" priority.

+1 RTBC

Wanted to echo that this is RTBC!

For any who want to start using it, you can bring it in by adding the following to your composer.json file:

{
    "repositories": {
        "block_token": {
            "type": "git",
            "url": "git@git.drupal.org:issue/block_token-3089830.git"
        },
        "drupal": {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": ["drupal/block_token"]
        },
    },
    "require": {
        "drupal/block_token": "dev-3089830-drupal-9-deprecated@dev",
        "drupal/core-recommended": "^9"
    }
}

One bit of warning that can be an issue to work on once this patch/merge request is accepted, if you use a token for a block that is not placed anywhere, or that you had placed but then removed, it causes a fatal error:

TypeError: Argument 1 passed to Drupal\block\BlockViewBuilder::view() must implement interface Drupal\Core\Entity\EntityInterface, null given, called in /var/www/html/web/modules/contrib/block_token/block_token.module on line 60 in /var/www/html/web/core/modules/block/src/BlockViewBuilder.php on line 31
/var/www/html/web/modules/contrib/block_token/block_token.module(147): block_token_block_render('socialsimpleblo...')

Disabling the block is fine but this is something to watch out for if someone might come along and clean up "unused" blocks.