Problem/Motivation

By request, I'm testing 8.x-2.3-rc1.

In #2969418: Allow a separate filter format for plain text vs. HTML emails we introduced forward_update_8201() to split the forward filter setting into an HTML vs. plain text setting.
Unfortunately, that update leaves the original setting still in config:

forward_filter_format: email_html

Since that's not defined in the schema, we get schema validation errors when you run tests after upgrading.
It's also leaking stuff into config we're no longer using, leading to possible confusion and human error.

Proposed resolution

Add a new update to purge the dead setting from config and re-save.

Remaining tasks

  1. Do it.
  2. Test.
  3. Commit.

User interface changes

None.

API changes

None.

Data model changes

None, really. Fixes a mismatch between actual config and expected config schema.

Release notes snippet

Probably none. TBD.

CommentFileSizeAuthor
#4 3089276-4.patch1.06 KBdww
#3 3089276-3.patch1.05 KBdww
#2 3089276-2.patch468 bytesdww

Comments

dww created an issue. See original summary.

dww’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new468 bytes
dww’s picture

StatusFileSize
new1.05 KB

Oh yeah, we should remove it from the default forward.settings.yml we ship, too. ;)

dww’s picture

StatusFileSize
new1.06 KB

Whoops, sorry, my local copy where I rolled the patch was accidentally a 8.x-3.x checkout. This should work better for the 8.x-2.x branch.

  • john.oltman committed eb181d6 on 8.x-2.x authored by dww
    Issue #3089276 by dww: forward_update_8201() leaves stale...
john.oltman’s picture

Status: Needs review » Fixed
dww’s picture

Thanks, and sorry for introducing this bug in the first place. ;)

Cheers,
-Derek

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.