drupal-check web/modules/contrib/login_destination
 14/14 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------
  Line   login_destination.module
 ------ ----------------------------------------------------------
  27     Call to deprecated method l() of class Drupal:
         in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Link instead.
         Example:
 ------ ----------------------------------------------------------

 ------ -------------------------------------------------------------------------------
  Line   src/Entity/LoginDestination.php
 ------ -------------------------------------------------------------------------------
  308    Call to deprecated method strpos() of class Drupal\Component\Utility\Unicode:
         in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
         mb_strpos() instead.
 ------ -------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------
  Line   src/LoginDestinationManager.php
 ------ -----------------------------------------------------------------------------------
  98     Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
         in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
         mb_strtolower() instead.
  135    Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
         in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
         mb_strtolower() instead.
 ------ -----------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------
  Line   tests/src/Functional/RedirectTest.php
 ------ ---------------------------------------------------------------------------
  204    Call to deprecated method getUsername() of class Drupal\user\Entity\User:
         in Drupal 8.0.0, will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Session\AccountInterface::getAccountName() or
         \Drupal\user\UserInterface::getDisplayName() instead.
  242    Call to deprecated method getUsername() of class Drupal\user\Entity\User:
         in Drupal 8.0.0, will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Session\AccountInterface::getAccountName() or
         \Drupal\user\UserInterface::getDisplayName() instead.
 ------ ---------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Traits/LoginDestinationCreationTrait.php (in context of class Drupal\Tests\login_destination\Functional\RedirectTest)
 ------ ---------------------------------------------------------------------------------------------------------------------------------
  28     Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:                                
         in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use                                                        
         mb_strtolower() instead.                                                                                         
 ------ ---------------------------------------------------------------------------------------------------------------------------------


 [ERROR] Found 7 errors
CommentFileSizeAuthor
#10 interdiff_8-10.txt3.07 KBsuresh prabhu parkala
#10 3087567-10.patch7.59 KBsuresh prabhu parkala
#8 interdiff_6-8.txt1.51 KBsuresh prabhu parkala
#8 3087567-8.patch6.44 KBsuresh prabhu parkala
#6 interdiff_2-6.txt5.25 KBgmangones
#6 login_destination-deprecated_code-3087567-6-8x_1x_dev.patch5.25 KBgmangones
#2 login_destination-deprecated_code-3087567-2-8x_1x_dev.patch4.82 KBdakruchko

Comments

dakruchko created an issue. See original summary.

dakruchko’s picture

dakruchko commented
StatusFileSize
new login_destination-deprecated_code-3087567-2-8x_1x_dev.patch4.82 KB

please review

dakruchko’s picture

dakruchko commented
Assigned: dakruchko » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: login_destination-deprecated_code-3087567-2-8x_1x_dev.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

rsvelko’s picture

rsvelko commented

At first sight all looks good. Will review once more, will test for regressions and will commit.
Cheers and thanks!

gmangones’s picture

gmangones commented
Status: Needs work » Needs review
StatusFileSize
new login_destination-deprecated_code-3087567-6-8x_1x_dev.patch5.25 KB
new interdiff_2-6.txt5.25 KB

Hi, was apply the patch and add line code of compatibility Drupal 8.7.10 || 9.

Thank's.

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Needs review » Needs work

I applied latest patch on latest dev but Upgrade status module still find one problem:

1 warning found.

web/modules/contrib/login_destination/src/LoginDestinationManager.php:
┌────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix │ 80 │ Parameter $alias_manager of method │
│ later │ │ Drupal\login_destination\LoginDestinationManager::__construc │
│ │ │ t() has typehint with deprecated interface │
│ │ │ Drupal\Core\Path\AliasManagerInterface. Deprecated in │
│ │ │ drupal:8.8.0 and is removed from drupal:9.0.0. Use │
│ │ │ \Drupal\path_alias\AliasManagerInterface. │
│ │ │ │
└────────┴──────┴──────────────────────────────────────────────────────────────┘

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3087567-8.patch6.44 KB
new interdiff_6-8.txt1.51 KB

Please review!

Status: Needs review » Needs work

The last submitted patch, 8: 3087567-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3087567-10.patch7.59 KB
new interdiff_8-10.txt3.07 KB

Please review the patch.

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Needs review » Reviewed & tested by the community

The patch looks good and Upgrade status module finds no more deprecation. Thank you!

rsvelko’s picture

rsvelko commented

The patch applies ok to 8.x branch. Those changes are cosmetic and nice to have.
About the core_version_requirement - we'll not use it on out current 8.x-1.x releases/branch, the way I see it, we'll have to release a 8.x-2.x branch that is compatible with D8.8+ and maybe a new one for 9.x.

rsvelko’s picture

rsvelko commented

I had to change Unicode::mb_strpos to mb_strpos etc and re-rolled the patch, or else the patch broke the module.

Also I decided to keep the 8.x-1.x branch of the module compatible with D8 below 8.8, and to add a 8.x-2.x branch of the module - compatible with D8.8+ and D9.

rsvelko’s picture

rsvelko commented
Status: Reviewed & tested by the community » Fixed

So to clarify: I've just added the 8.x-2.x branch of the module - and committed the changes to it ONLY.
This 8.x-2.x will be the branch in which we will fix the deprecated code.
8.x-1.x will remain with the deprecated functions and will remain compatible with drupal versions below 8.8.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joshua.boltz’s picture

joshua.boltz commented

FYI, additional deprecation issues have been fixed in https://www.drupal.org/project/login_destination/issues/3145855