The domain field in the languages table is a varchar with length of 128. However the form which allows you to modify this variable (e.g. admin/settings/language/edit/es) specifies a max_length of 64 characters on this field. Since these amounts differ I'm marking this a bug. The max_length should be extended to 128 characters.

Technically a domain name can be very long according to http://en.wikipedia.org/wiki/Domain_name_system#Parts_of_a_domain_name (basically 64 x 127 characters). Whilst unnecessary to support this length, it would make sense to at least extend the length to what the DB currently allows.

I personally am working on a project where the client required a really long domain name and so I actually ran into this bug - I was unable to enter the entire domain name into the box. I solved the problem with the attached patch - please review.

CommentFileSizeAuthor
locale-extended-domain.patch932 bytesfletchgqc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Version: 6.x-dev » 7.x-dev
Status: Needs review » Reviewed & tested by the community

Verified that the DB indeed allows for 128, so trivial patch. Thanks, committed to 6.x! Also marking RTBC for 7.x.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks fletchgqc.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.