Module should use the new https://github.com/PHPOffice/PhpSpreadsheet library instead of deprecated https://github.com/PHPOffice/PHPExcel.

CommentFileSizeAuthor
#7 3086234-phpspreadsheet-support-7.patch.txt22.32 KBberliner
#3 3086234-phpspreadsheet-support-3.patch22.39 KBberliner
#2 3086234-phpspreadsheet-support-2.patch23.15 KBberliner

Issue fork phpexcel-3086234

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berliner created an issue. See original summary.

berliner’s picture

berliner commented
Status: Active » Needs review
StatusFileSize
new 3086234-phpspreadsheet-support-2.patch23.15 KB

I have created a first patch based on the one in #3016486: PHP 7 and PhpSpreadsheet support (PHPOffice/PHPExcel deprecated). Working so far for a simple export, I didn't test for imports as I don't have a test case for that lying around.

berliner’s picture

berliner commented
StatusFileSize
new 3086234-phpspreadsheet-support-3.patch22.39 KB

Corrected the patch as the first other one didn't apply properly.

matthieu_collet’s picture

matthieu_collet commented

is it the correct path for phpspreadsheet ?

/libraries/PhpSpreadsheet/src/Bootstrap.php

berliner’s picture

berliner commented

@matthieu_collet Not sure if that works as I use composer to install the libraries which installs into vendor, see the updated README.txt in the patch.

matthieu_collet’s picture

matthieu_collet commented

thank you @berliner
typo in the readme : you need to delete the "s" at the end

berliner’s picture

berliner commented
StatusFileSize
new 3086234-phpspreadsheet-support-7.patch.txt22.32 KB

Ah, good catch, corrected in the new patch.

dravenk made their first commit to this issue’s fork.

dravenk opened merge request !1

dravenk’s picture

dravenk
He/Him
Primary language English
commented

I tested in PHP 8.0 and it working for me. Thank you @berliner.

superfluousapostrophe’s picture

superfluousapostrophe commented

I know this is a fairly old issue, but I cannot seem to get the patch to apply to the current dev release via composer. Any chance you could re-roll it? The end of PHP7 is coming faster than we can get our D7 site migrated so I need to get this module working on PHP8 ASAP.

berliner’s picture

berliner commented

@SuperfluousApostrophe This patch is for D8. Did you have a look at #3016486: PHP 7 and PhpSpreadsheet support (PHPOffice/PHPExcel deprecated) already? Maybe that works with PHP 8?

superfluousapostrophe’s picture

superfluousapostrophe commented

...and that's what I get for not paying attention. Thanks for pointing me in the right direction. Sorry about that!

  • dravenk committed dc7502d on 8.x-3.x 
    Issue #3086234 by berliner: PhpSpreadsheet support (PHPOffice/PHPExcel...

dravenk closed merge request !1

dravenk’s picture

dravenk
He/Him
Primary language English
commented
Status: Needs review » Fixed

Committed to the last dev version. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.