ProfileStorage::loadDefaultByUser() is deprecated and should be replaced by loadByUser().
This probably means renaming AddressBook::loadDefault() as well.

AddressBook::loadAll() needs to stop sorting profiles because they're now properly presorted. This will require a few test changes in places that relied on a specific order.

CommentFileSizeAuthor
#2 3077908-2.patch7.81 KBbojanz

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz commented
Status: Active » Needs review
StatusFileSize
new 3077908-2.patch7.81 KB

Initial work.

The new sorting is really an improvement (ensures the default profile is always first).

  • bojanz committed 7beeb4d on 8.x-2.x 
    Issue #3077908 by bojanz: Update the Address Book service for Profile 1....
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed #2. We can rename AddressBook::loadDefault() in another issue if we decide we want to, I don't want to postpone the sorting fixes on that.

  • bojanz committed 8b9b61b on 8.x-2.x 
    Issue #3077908 followup: Rename AddressBook::loadDefault to AddressBook...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.