Drupal 9 Deprecated Code Report

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.

Adding patch to remove other deprecation.

Please consider this patch above one was miss upload. Please review!!

Patch #6 works good.

drupal-check -d web/modules/contrib/structure_sync
11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------
Line src/Controller/BlocksController.php
------ ------------------------------------------
93 Call to deprecated function drush_log().
248 Call to deprecated function drush_log().
299 Call to deprecated function drush_log().
322 Call to deprecated function drush_log().
375 Call to deprecated function drush_log().
393 Call to deprecated function drush_log().
419 Call to deprecated function drush_log().
------ ------------------------------------------

------ ------------------------------------------
Line src/Controller/MenuLinksController.php
------ ------------------------------------------
78 Call to deprecated function drush_log().
235 Call to deprecated function drush_log().
344 Call to deprecated function drush_log().
400 Call to deprecated function drush_log().
418 Call to deprecated function drush_log().
445 Call to deprecated function drush_log().
------ ------------------------------------------

------ ------------------------------------------
Line src/Controller/TaxonomiesController.php
------ ------------------------------------------
147 Call to deprecated function drush_log().
314 Call to deprecated function drush_log().
468 Call to deprecated function drush_log().
497 Call to deprecated function drush_log().
618 Call to deprecated function drush_log().
678 Call to deprecated function drush_log().
785 Call to deprecated function drush_log().
------ ------------------------------------------

[ERROR] Found 20 errors

The patch from #10 seemed to work for me on the dev version of the module. Is there anything else to worry about?

11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


[OK] No errors                                                                                                         

Patch in #10 seems to resolve this. Marking RTBC.

Thanks! See the new 2.0.0 release.

You may want to track #3141810: Automated Drupal Rector fixes for future things.

The following code:

  public static function taxonomiesImportFinishedCallback($success, $results, $operations) {
    StructureSyncHelper::logMessage('Successfully imported taxonomies');

    $this->messenger()->addStatus(t('Successfully imported taxonomies'));
  }

...is causing:

Error: Using $this when not in object context in Drupal\structure_sync\Controller\TaxonomiesController::taxonomiesImportFinishedCallback() (line 822 of /app/web/modules/contrib/structure_sync/src/Controller/TaxonomiesController.php) #0 /app/web/modules/contrib/structure_sync/src/Controller/TaxonomiesController.php(221): Drupal\structure_sync\Controller\TaxonomiesController::taxonomiesImportFinishedCallback(NULL, NULL, NULL)

That needs to be a global call. Working on it.

Fixed as per drupal_set_message() and drupal_get_messages() replaced by Messenger service.

But now I'm seeing:

Error: Class 'Drupal\structure_sync\Controller\TaxonomiesController' not found in Drupal\structure_sync\StructureSyncHelper::importTaxonomies() (line 47 of /app/web/modules/contrib/structure_sync/src/StructureSyncHelper.php)

Any ideas? Looks like it's there to me.

This is failing on:

drush --verbose import-taxonomies --choice safe

If we had tests, this would have been caught earlier. I just created #3175581: Add tests.

As this turned out to be more of a mess than expected, I reverted the bad commit and cut a new release.

This patch appears to conflate drush logging with Drupal logging and uses $this in static functions, etc.

Marking as a duplicate of #3141810: Automated Drupal Rector fixes