Responsive image formatter does not support URL/Link options

I can also confirm that the patch works well for me.
Just a case of fixing the failing tests.

Patch looks good, nice test coverage and fix is in line with the fix in #2829990: Image formatter does not support URL/Link options

The 9.1.x test failed with:

mage.Drupal\Tests\responsive_image\Kernel\ResponsiveImageFormatterTest
✗	
Drupal\Tests\responsive_image\Kernel\ResponsiveImageFormatterTest
fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-516.xml:
PHPunit Test failed to complete; Error: PHPUnit 8.5.3 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\responsive_image\Kernel\ResponsiveImageFormatterTest
W                                                                   1 / 1 (100%)

Time: 2.27 seconds, Memory: 4.00 MB

There was 1 warning:

1) Drupal\Tests\responsive_image\Kernel\ResponsiveImageFormatterTest::testImageFormatterUrlOptions
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:691

WARNINGS!
Tests: 1, Assertions: 8, Warnings: 1.

Remaining self deprecation notices (1)

  1x: Declaring ::setUp without a void return typehint in Drupal\Tests\responsive_image\Kernel\ResponsiveImageFormatterTest is deprecated in drupal:9.0.0. Typehinting will be required before drupal:10.0.0. See https://www.drupal.org/node/3114724
    1x in DrupalListener::startTest from Drupal\Tests\Listeners

Here I have added a patch that might pass failed tests.

This patch might pass the tests.

There was an issue in the patch #17, so added a new patch for review.

+++ b/core/modules/responsive_image/src/Plugin/Field/FieldFormatter/ResponsiveImageFormatter.php
@@ -230,7 +230,7 @@ public function viewElements(FieldItemListInterface $items, $langcode) {
-        $url = $file->createFileUrl();
+        $url = Url::fromUri($file->createFileUrl(FALSE));

Why are we mixing this change with a change to whether this is absolute or not. That doesn't seem something that should occur without discussion and doesn't seem to be in-scope.

Also as we're changing the type of a theme variable from a string to a Url object we should have a change record.

Re-rolled patch #18 for 9.3.x

The failure of tests for patch 3064751-26-test-only.patch from #26 above, demonstrate the tests are working and the patch fixes the isse:

Setting back to Needs review.
Thanks in advance!

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

IS proposed solution appears to match what is being accomplished in the patch. - Good
Tests only patch is showing red/green - Good

At this time we will need a D10.1.x version of the patch. (Should be close but instead of stable it's stable9 now)

Also the CR think could use an update to mention the change being done to the twig templates. If themers have their own responsive-image-formatter.html.twig they will have to update to work correct.

Added reroll of patch #26 on Drupal 10.1.x. keeping the status to needs work for other things of comment #31.

Small comments, but super close!

I meant we could drop the @var since it’s typed. Sorry

Thanks sorry I wasn’t clear the first time. Feedback appears to be addressed nothing else to add

I made a couple minor changes to the MR:
In ResponsiveImageFormatter.

• Removed property promotion of the new $fileUrlGenerator constructor parameter. This is to avoid making the property itself nullable.

In ResponsiveImageFormatterTest:

• Removed the mb_strolower wrapping of $this->randomMachineName(), since the generated random machine name is already all lower.
• Generated only 1 sample file, since that's all that's needed for the test

If someone could give this a +1 for RTBC, I can commit.

Committed and and pushed a85f1db to main and 458eb45 to 11.x. Thanks!

I forgot to mention I made some small edits to the CR the last time I reviewed. I have published the CR now as well.