Image formatter does not support URL/Link options

In 8.3.0 you will be able to get the URL separately.

This is still a problem in the latest version of Drupal.

I think the main problem is that the Image object gets a "URL" attribute which doesn't represent an anchor tag (link) so it has no attributes like a class or title.

I met with this problem when I wanted to extend Thumbnail formatter to show content link in the modal. I think that image-formatter.html.twig should be using link function to generate correctly link. I attach a patch but you can copy image-formatter.html.twig file to your theme and fix it manually.

I removed the unnecessary code (vendor) from the patch #6.

Thanks, but we need a test here to make sure it doesn't have a regression

Attached patch implements the following changes:

1. Added a new test method to \Drupal\Tests\image\Kernel\ImageFormatterTest showing the shortcoming of the current API.
2. Removed the empty optional arguments to twig's link() function.
3. Extended the change in core/modules/image/templates/image-formatter.html.twig to all image-formatter.html.twig files in Drupal Core.

The changes look good.

I just removed the unnecessary code.

--- a/core/modules/image/tests/src/Kernel/ImageFormatterTest.php
+++ b/core/modules/image/tests/src/Kernel/ImageFormatterTest.php
@@ -178,9 +178,7 @@ public function testImageFormatterSvg() {
    * Tests Image Formatter URL options handling.
    */
   public function testImageFormatterUrlOptions() {
-    $field_formatter_configuration = $this->display->getComponent($this->fieldName);
-    $field_formatter_configuration['settings']['image_link'] = 'content';
-    $this->display->setComponent($this->fieldName, $field_formatter_configuration);
+    $this->display->setComponent($this->fieldName, ['settings' => ['image_link' => 'content']]);

#12 Nice cleanup!

Note that responsive-image-formatter.html.twig uses an identical pattern:

{% if url %}
  <a href="{{ url }}">{{ responsive_image }}</a>
{% else %}
  {{ responsive_image }}
{% endif %}

in core/modules/responsive_image/templates/responsive-image-formatter.html.twig

I am not sure if this should be fixed in this issue as well or in a follow-up.

#15 Unrelated random test failure. Back to RTBC.

Committed 3e8c2b3 and pushed to 8.8.x. Thanks!

c/p to 8.7.x

#14 Filed a follow up issue for the Responsive Image formatter at #3064751: Responsive image formatter does not support URL/Link options