The \Drupal::entityQuery calls are replaced by \Drupal::entityTypeManager() calls.
So this way we dont have query in the view layer.

CommentFileSizeAuthor
#6 site-settings-issue-3063966-6.patch6.47 KBnagy.balint
#3 site-settings-issue-3063966-3.patch6.39 KBmr.york
#2 site-settings-issue-3063966-2.patch6.39 KBmr.york

Comments

mr.york created an issue. See original summary.

mr.york’s picture

mr.york commented
StatusFileSize
new site-settings-issue-3063966-2.patch6.39 KB

Attached patch.

mr.york’s picture

mr.york commented
StatusFileSize
new site-settings-issue-3063966-3.patch6.39 KB

Fixed typos.

nagy.balint’s picture

nagy.balint commented
Status: Active » Needs review
scott_euser’s picture

scott_euser commented
Status: Needs review » Needs work

This patch unfortunately does not apply any more after the last couple of commits. Otherwise in general looks fine thanks!

nagy.balint’s picture

nagy.balint commented
Status: Needs work » Needs review
StatusFileSize
new site-settings-issue-3063966-6.patch6.47 KB

Rerolled the patch.

I tested it, and fixed an issue at SimpleSiteSettingsBlock in the patch where the condition was incorrect.

scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Thanks!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.