Problem/Motivation

#3052254: Clean up profile types removed getMultiple from ProfileTypeInterface which broke the tests here.

CommentFileSizeAuthor
#10 3060781-9.patch3.11 KBquietone
#8 3060781-8.patch2.51 KBquietone
#4 allowsMultiple-replaces-GetMultiple-4.patch1.35 KBquietone
allowsMultiple-replaces-GetMultiple.patch678 bytesquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, allowsMultiple-replaces-GetMultiple.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented

Well this isn't fun. The failing tests pass locally with this patch.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Needs work » Needs review
FileSize
allowsMultiple-replaces-GetMultiple-4.patch1.35 KB

This should do it. It seems that use_revisions has gone away as well.

  • quietone committed 527ee55 on 8.x-2.x 
    Issue #3060781 by quietone: ProfileType::getMultiple removed
quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Needs review » Fixed
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented 
+      allow_revisions: true
+      new_revision: true

Why true? Commerce doesn't use revisions on profile types. It's a profile feature meant for non-Commerce use cases.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Fixed » Needs work
FileSize
3060781-8.patch2.51 KB

Oops. Yes, let's change that.

  • quietone committed dc572d1 on 8.x-2.x 
    Revert "Issue #3060781 by quietone: ProfileType::getMultiple removed"...
quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Needs work » Needs review
FileSize
3060781-9.patch3.11 KB

Making a new patch

Status: Needs review » Needs work

The last submitted patch, 10: 3060781-9.patch, failed testing. View results

  • quietone committed 742470f on 8.x-2.x 
    Issue #3060781 by quietone: ProfileType::getMultiple removed
quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.