Problem/Motivation

  1. Install 8.7.1
  2. Go to /admin/modules
  3. Expand the Description for JSON:API

Notice there is no Version: 8.7.1 listed with the other requirements/details.

Adding "version: VERSION" to jsonapi.info.yml solves the problem.

Proposed resolution

Add a test to ensure all core provided modules have a version key with the expected value.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#11 3053897-11.patch2.14 KBwebflo
#7 3053897-7.patch2.12 KBalexpott
#7 3053897-7.test-only.patch1.1 KBalexpott
#7 5-7-interdiff.txt510 bytesalexpott
#5 3053897-5.patch2.12 KBalexpott
#5 3053897-5.test-only.patch1.1 KBalexpott
#2 3053897-No-version-key-value-pair-in-jsonapi-info-yml.patch444 bytesuptil4music
No-version-key-value-pair-in-jsonapi-info-yml.png15.21 KBuptil4music

Comments

UpTil4Music created an issue. See original summary.

uptil4music’s picture

uptil4music commented
Status: Active » Needs review
StatusFileSize
new 3053897-No-version-key-value-pair-in-jsonapi-info-yml.patch444 bytes
gabesullice’s picture

gabesullice
Primary language English
commented
Version: 8.8.x-dev » 8.7.x-dev
Assigned: uptil4music » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
Issue tags: +API-First Initiative

Hah, nice catch 🤓

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: No version key/value pair in jsonapi.info.yml » No version key/value pair in new core modules (json_api, migrate_drupal_multilingual)
Component: jsonapi.module » base system
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3053897-5.test-only.patch1.1 KB
new 3053897-5.patch2.12 KB

This doesn't affect just the json_api module - let's add a test so we don't forget this in the future.

Status: Needs review » Needs work

The last submitted patch, 5: 3053897-5.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 5-7-interdiff.txt510 bytes
new 3053897-7.test-only.patch1.1 KB
new 3053897-7.patch2.12 KB

Messed up the test namespace.

The last submitted patch, 7: 3053897-7.test-only.patch, failed testing. View results

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.9 was released on November 6 and is the final full bugfix release for the Drupal 8.7.x series. Drupal 8.7.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.8.0 on December 4, 2019. (Drupal 8.8.0-beta1 is available for testing.)

Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

webflo’s picture

webflo commented
StatusFileSize
new 3053897-11.patch2.14 KB

I noticed this issue while working on the composer deploy module. Reroll!

webflo’s picture

webflo commented
Version: 8.9.x-dev » 9.2.x-dev
init90’s picture

init90
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 944bcb1 on 9.2.x 
    Issue #3053897 by alexpott, UpTil4Music, webflo: No version key/value...

  • catch committed 0ca0f2c on 9.1.x 
    Issue #3053897 by alexpott, UpTil4Music, webflo: No version key/value...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.