Problem/Motivation

\Drupal\Tests\taxonomy\Functional\Views\RelationshipNodeTermDataTest makes no HTTP requests but is a functional test.

Proposed resolution

- Convert \Drupal\Tests\taxonomy\Functional\Views\RelationshipNodeTermDataTest into a Kernel test.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3046959-2.patch0 bytesclaudiu.cristea

Issue fork drupal-3046959

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

Status: Active » Postponed
StatusFileSize
new0 bytes

This is postponed on #3041030: Convert functional EfqTest to a kernel test and move TaxonomyTestTrait from tests/src/Functional to tests/src/Traits because it needs the trait implemented there. Uploading the progress done so far.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Status: Postponed » Active
spokje’s picture

Assigned: Unassigned » spokje
spokje’s picture

Title: Convert RelationshipNodeTermDataTest into a Kernel test » Convert RelationshipNodeTermDataTest and RelationshipRepresentativeNodeTest into Kernel tests, drop TaxonomyTermFilterDepthTest Functional test
Issue summary: View changes
spokje’s picture

Issue summary: View changes

spokje’s picture

Assigned: spokje » Unassigned
Status: Active » Needs review
spokje’s picture

Willing to split this up into three separate issues if this would make reviewing/committing easier.
Just don't want to be accused of credit farming. (Dear lord, if there's something I _don't_ need it's more core credits...;)

spokje’s picture

Title: Convert RelationshipNodeTermDataTest and RelationshipRepresentativeNodeTest into Kernel tests, drop TaxonomyTermFilterDepthTest Functional test » Convert RelationshipNodeTermDataTest into a Kernel test
Issue summary: View changes
Parent issue: #3041700: [META] Convert some tests into Kernel or Unit tests » #3414655: [META] Convert Functional tests classes which make no HTTP requests into Kernel tests
spokje’s picture

I've split this up into three separate issues.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Conversion looks good

  • catch committed f776bd3f on 10.2.x
    Issue #3046959 by Spokje, claudiu.cristea: Convert...

  • catch committed 74668486 on 11.x
    Issue #3046959 by Spokje, claudiu.cristea: Convert...
catch’s picture

Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.