Convert functional EfqTest to a kernel test and move TaxonomyTestTrait from tests/src/Functional to tests/src/Traits

+++ b/core/modules/taxonomy/tests/src/Kernel/Views/TaxonomyFieldVidTest.php
similarity index 69%
rename from core/modules/taxonomy/tests/src/Functional/TaxonomyTestTrait.php

rename from core/modules/taxonomy/tests/src/Functional/TaxonomyTestTrait.php
rename to core/modules/taxonomy/tests/src/Traits/TaxonomyTestTrait.php

I'm pretty sure we can't do that without a BC layer.

Just some notes, nothing blocking I think.

1. +++ b/core/modules/system/tests/src/Functional/Module/PrepareUninstallTest.php
   index eb9e5e983b..7a980bd148 100644
   --- a/core/modules/taxonomy/src/Tests/TaxonomyTestBase.php
   
   --- a/core/modules/taxonomy/src/Tests/TaxonomyTestBase.php
   +++ b/core/modules/taxonomy/src/Tests/TaxonomyTestBase.php
   
   +++ b/core/modules/taxonomy/src/Tests/TaxonomyTestBase.php
   @@ -6,7 +6,7 @@
   -use Drupal\Tests\taxonomy\Functional\TaxonomyTestTrait;
   +use Drupal\Tests\taxonomy\Traits\TaxonomyTestTrait;
   

   Not strictly necessary since it's updating a class that is deprecated itself.

2. +++ b/core/modules/taxonomy/tests/src/Functional/TaxonomyTestTrait.php
   @@ -2,58 +2,20 @@
   +@trigger_error('The ' . __NAMESPACE__ . '\TaxonomyTestTrait is deprecated in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Instead, use \Drupal\Tests\taxonomy\Traits\TaxonomyTestTrait. See https://www.drupal.org/node/3041703.', E_USER_DEPRECATED);
   

   See #3024461: Adopt consistent deprecation format for core and contrib deprecation messages for the new way of writing these, since this has not been officially approved, not setting it back now (but might have to update this is that lands first)

Went through the conversion and everything checks out.

The only part I'm missing that is mentioned in the IS is: "Rename it to a more meaningful name", which I think is worth doing.

The test class has been renamed from EfqTest to TaxonomyTermEfqTest

Ah ok, I was looking for hopefully getting rid of 'Efq', why not just say TaxonomyTermEntityFieldQueryTest. No need to wrack my brain thinking what 'Efq' would stand for.

Can we also change the name of the method testTaxonomyEfq() to testTaxonomyEntityQuery()?

core/modules/taxonomy/tests/src/Kernel/TaxonomyTermEntityQueryTest.php:31:

/**
 * Tests that a basic taxonomy entity query works.
 */
 public function testTaxonomyEfq() {

I'd suggest testTermEntityQuery then, possibly for the class name also leave out the Taxonomy.

1. I changed trigger_error() message. Drupal core deprecation policy.

The PHPdoc text and the trigger_error() message should follow the same format

According to #12:

2. I changed the class name from TaxonomyTermEntityQueryTest to TermEntityQueryTest.

3. I changed the name of the method testTaxonomyEfq() to testTermEntityQuery()

Thanks for all the feedback, this reads much better now.

Nice conversion, no loss of coverage that I can see.

New deprecation introduced due to #3042640: Convert TaxonomyFieldTidTest to a kernel test.

Committed 6874218 and pushed to 8.8.x. Thanks!

FYI: The change record for this was never published. I just did so.

I also figured out how to get my contrib tests that were trying to use this trait to work on 8.7.x and 8.8.x and above, so I added that wisdom to the CR:

https://www.drupal.org/node/3041703/revisions/view/11349728/11635421

Enjoy,
-Derek