Inline content blocks created by layout builder should not directly be impacted by content moderation

+1 I think delegating if the entity is moderated to the Moderation handler is worth exploring.

Makes sense, we already have a pseudo-official of opting out entirely by unsetting the moderation handler, terms and menu_link_content is doing that now in 8.7, but not yet dynamically based on some condition.

The entity type actually returns the handler as a string. This should do it.

well, introducing whitespace doesn't, but this should :p

Fixing last tests. Had to update the mocks.

I've re-queued the test. Assuming it's still green, this looks good to me. The addition of the isModeratedEntity method to the handler is a great solution, and will provide flexibility in the future for other entity types that want more granular control of which entities are moderated.

+++ b/core/modules/content_moderation/src/ModerationInformation.php
@@ -52,8 +52,10 @@ public function isModeratedEntity(EntityInterface $entity) {
+    return  $this->entityTypeManager->getHandler($entity->getEntityTypeId(), 'moderation')->isModeratedEntity($entity);

nit two spaces here, can be fixed on commit

Tagging for needs change record, adding a new method to the interface is allowed under the 1:1 rule, as it is expected that implementations will extend from the base class.

+++ b/core/modules/content_moderation/src/ModerationInformation.php
@@ -52,8 +52,10 @@ public function isModeratedEntity(EntityInterface $entity) {
     }
-
-    return $this->shouldModerateEntitiesOfBundle($entity->getEntityType(), $entity->bundle());
+    if (!$this->shouldModerateEntitiesOfBundle($entity->getEntityType(), $entity->bundle())) {
+      return FALSE;
+    }
+    return  $this->entityTypeManager->getHandler($entity->getEntityTypeId(), 'moderation')->isModeratedEntity($entity);
   }

This means that code that checks for this needs two check at least two methods now. What about deprecating shouldModerateEntitiesOfBundle() and testing that in isModeratedEntity() too?

Possibly as a follow-up?

Works for me, that we sometimes don't have an entity is a fair point, and as I said, the actual API when having an entity is ModerationInformation::isModeratedEntity(), so nothing changes.

Crediting @Berdir for reviews

Tagging this as bug-smash initiative as I've come back to it after it came up in our fortnightly meeting.

Fixed on commit

-    return  $this->entityTypeManager->getHandler($entity->getEntityTypeId(), 'moderation')->isModeratedEntity($entity);
+    return $this->entityTypeManager->getHandler($entity->getEntityTypeId(), 'moderation')->isModeratedEntity($entity);

Committed 695846b and pushed to 9.1.x. Thanks!

Leaving as RTBC and moving to 9.0.x

Will poll other committers about a possible backport - the issue here is we're adding a new method - which we normally only do in a minor release - because in theory a handler may already have a similarly named method, but with a slightly different signature - and in that case a backport would break that.

FYI here introduced a typo "apears" in core/modules/content_moderation/tests/src/Functional/LayoutBuilderContentModerationIntegrationTest.php

Here's a patch with the fixed spelling mistake and also a coding standards fix...

Discussed this with @catch - as we're adding a new method here, there is risk of disruption. As this is only a normal bug, this will be 9.1.x only.

Thanks all.