handleUpload uses coninue in a switch: https://cgit.drupalcode.org/dropzonejs/tree/src/UploadHandler.php
Triggering a PHP error:

PHP 7.3 Bug: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"

CommentFileSizeAuthor
#5 3043246-6.patch934 byteschr.fritsch
#4 3043246-4.patch1.5 KBchr.fritsch
#2 3043246-2.patch934 byteschr.fritsch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Version: 8.x-2.x-dev » 8.x-1.x-dev
Status: Active » Needs review
FileSize
3043246-2.patch934 bytes

Here is a patch. Let's fix this first on 8.x-1.x and then on 8.x-2.x

Status: Needs review » Needs work

The last submitted patch, 2: 3043246-2.patch, failed testing. View results

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Needs review
FileSize
3043246-4.patch1.5 KB

$this->tmpFile was assigned twice, but the first one is not needed.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
3043246-6.patch934 bytes

Re-uploading #2 to test on 8.x-2.x

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs review » Reviewed & tested by the community

We have now also green test on Thunder with 7.3

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Reviewed & tested by the community » Fixed

Let's close this. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.