Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/reroute_email f0f387036c6b7b6829b96235528816cb6e4dc65f
source : http://cgit.drupalcode.org/reroute_email 


 ------ ------------------------------------------------- 
  Line   reroute_email.module                             
 ------ ------------------------------------------------- 
  234    Call to deprecated method strtolower() of class  
         Drupal\Component\Utility\Unicode.                
  252    Call to deprecated method strtolower() of class  
         Drupal\Component\Utility\Unicode.                
 ------ ------------------------------------------------- 

 ------ ----------------------------------------------------- 
  Line   tests/src/Functional/ContactTest.php                 
 ------ ----------------------------------------------------- 
  41     Call to deprecated method assertResponse() of class  
         Drupal\Tests\BrowserTestBase.                        
  69     Call to deprecated method assertResponse() of class  
         Drupal\Tests\BrowserTestBase.                        
  70     Call to deprecated method assertText() of class      
         Drupal\Tests\BrowserTestBase.                        
  87     Call to deprecated method assertText() of class      
         Drupal\Tests\BrowserTestBase.                        
  100    Call to deprecated method assertText() of class      
         Drupal\Tests\BrowserTestBase.                        
  111    Call to deprecated method assertText() of class      
         Drupal\Tests\BrowserTestBase.                        
  118    Call to deprecated method assertEqual() of class     
         Drupal\Tests\BrowserTestBase.                        
 ------ ----------------------------------------------------- 

 ------ --------------------------------------------------------- 
  Line   tests/src/Functional/DefaultAddressesTest.php            
 ------ --------------------------------------------------------- 
  51     Call to deprecated method assertFieldChecked() of class  
         Drupal\Tests\BrowserTestBase.                            
  55     Call to deprecated method assertFieldByName() of class   
         Drupal\Tests\BrowserTestBase.                            
  62     Call to deprecated method assertText() of class          
         Drupal\Tests\BrowserTestBase.                            
  63     Call to deprecated method assert() of class              
         Drupal\Tests\BrowserTestBase.                            
  92     Call to deprecated method assertPattern() of class       
         Drupal\Tests\BrowserTestBase.                            
  107    Call to deprecated method assertPattern() of class       
         Drupal\Tests\BrowserTestBase.                            
 ------ --------------------------------------------------------- 

 ------ -------------------------------------------------- 
  Line   tests/src/Functional/DomainWhitelistedTest.php    
 ------ -------------------------------------------------- 
  24     Call to deprecated method assertEqual() of class  
         Drupal\Tests\BrowserTestBase.                     
  25     Call to deprecated method assertEqual() of class  
         Drupal\Tests\BrowserTestBase.                     
 ------ -------------------------------------------------- 

 ------ -------------------------------------------------- 
  Line   tests/src/Functional/MultipleRecipientsTest.php   
 ------ -------------------------------------------------- 
  26     Call to deprecated method assertEqual() of class  
         Drupal\Tests\BrowserTestBase.                     
  27     Call to deprecated method assertEqual() of class  
         Drupal\Tests\BrowserTestBase.                     
 ------ -------------------------------------------------- 

 ------ ------------------------------------------------- 
  Line   tests/src/Functional/RerouteEmailTestBase.php    
 ------ ------------------------------------------------- 
  131    Call to deprecated method assertText() of class  
         Drupal\Tests\BrowserTestBase.                    
  148    Call to deprecated method assert() of class      
         Drupal\Tests\BrowserTestBase.                    
 ------ ------------------------------------------------- 

 ------ -------------------------------------------------------- 
  Line   tests/src/Functional/TestEmailFormTest.php              
 ------ -------------------------------------------------------- 
  30     Call to deprecated method assertFieldByName() of class  
         Drupal\Tests\BrowserTestBase.                           
  41     Call to deprecated method assertText() of class         
         Drupal\Tests\BrowserTestBase.                           
  76     Call to deprecated method assertText() of class         
         Drupal\Tests\BrowserTestBase.                           
 ------ -------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   tests/src/Functional/UnusualMessageFieldsTest.php  
 ------ --------------------------------------------------- 
  81     Call to deprecated method assertRaw() of class     
         Drupal\Tests\BrowserTestBase.                      
 ------ --------------------------------------------------- 

 [ERROR] Found 25 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3042834-10.patch12.97 KBbohart
#7 3042834.patch14.67 KBeiriksm
#6 drupal_9_deprecated_code-3042834-6.patch14.28 KBsergiu stici
#4 drupal_9_deprecated_code-3042834-4.patch14.42 KBsergiu stici
#2 drupal_9_deprecated_code-3042834-2.patch14.48 KBsergiu stici

Comments

mcdwayne created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042834-2.patch14.48 KB

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3042834-2.patch, failed testing. View results

sergiu stici’s picture

sergiu stici commented
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042834-4.patch14.42 KB

Status: Needs review » Needs work

The last submitted patch, 4: drupal_9_deprecated_code-3042834-4.patch, failed testing. View results

sergiu stici’s picture

sergiu stici commented
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042834-6.patch14.28 KB
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
StatusFileSize
new 3042834.patch14.67 KB

Updated the patch to indicate in the info file that the module is compatible

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Title: Drupal 9 Deprecated Code Report » Drupal 10 Deprecated Code Report
Status: Needs review » Needs work
Issue tags: -Drupal 9 compatibility

Most of the deprecations are not relevant for the "Drupal 9", because they will be removed in Drupal 10.
I would recommend tracking Drupal 9 progress here: #3138033: Drupal 9 compatibility and leave this task for the rest of deprecations.

Moving back to "Needs work" because of the failed tests in #7.

  • bohart committed f3039dc on 2.x 
    Issue #3042834 by bohart: The core_version_requirement constraint (^9)...
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Version: 8.x-1.x-dev » 2.x-dev
StatusFileSize
new 3042834-10.patch12.97 KB

#3138033: Drupal 9 compatibility is committed already.

The new release branch was created for Drupal 9 (Drupal 10 compatibility will be pushed there).

Here is an updated patch, let's give a chance for DrupalCI to test it out.

  • bohart committed c8bb46a on 2.x authored by Sergiu Stici 
    Issue #3042834 by Sergiu Stici, eiriksm, bohart, mcdwayne, Matroskeen:...
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs work » Fixed

Committed to && tested on: 2.x-dev (Drupal 9) branch.

Thanks, @all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.