Drupal 9 Deprecated Code Report for R4032Login module

Here is the patch, please review.

Hello @mcdwayne,
Please review.

+++ b/src/EventSubscriber/R4032LoginSubscriber.php
@@ -166,7 +166,7 @@ class R4032LoginSubscriber extends HttpExceptionSubscriberBase {
+          \Drupal::messenger()->addMessage(Xss::filterAdmin($message), $messageType);

This should use dependency injection instead.

Also, there are still failures on the testbot:

1) Drupal\Tests\r4032login\Functional\RedirectTest::testSkipRedirect with data set #0 ('/admin/config/development', array(), 403, '/admin/config/development')
Behat\Mink\Exception\ExpectationException: Current response status code is 200, but 403 expected.

/var/www/html/vendor/behat/mink/src/WebAssert.php:770
/var/www/html/vendor/behat/mink/src/WebAssert.php:130
/var/www/html/modules/contrib/r4032login/tests/src/Functional/RedirectTest.php:46

2) Drupal\Tests\r4032login\Functional\RedirectTest::testSkipRedirect with data set #2 ('/admin/modules', array(array('bar')), 403, '/admin/modules?foo=bar')
Behat\Mink\Exception\ExpectationException: Current response status code is 200, but 403 expected.

/var/www/html/vendor/behat/mink/src/WebAssert.php:770
/var/www/html/vendor/behat/mink/src/WebAssert.php:130
/var/www/html/modules/contrib/r4032login/tests/src/Functional/RedirectTest.php:46

Updated patch to use dependency injection. Tests are passing locally, so we'll see what testbot says...

#7 wasn't addressed, working on this now.

Oh, patch from #10 (#11 and #12) did not contain changes from #8, which already addressed #7 with dependency injection. I have combined patch #10 and #12 and finally removed the obsolete function "drupal_set_message()" from the unit test.

@pminf: there are 2 things to improve from my perspective:

1. Remove the space after the arrow:
   
   $kernel = $this-> createMock('Symfony\Component\HttpKernel\HttpKernelInterface');
2. @param MessengerInterface $messenger;: the trailing ; needs to be removed

Changed last recommendations from @gogowisch and applied a new patch. Tested and reviewed - works fine, all errors from drupal-check are gone after applying.

Forgot one semikolon ^^

Thanks! #17 and #18 addressed #16. Everything should be fine now.

Get info file compatilble with Drupal 9

See: https://www.drupal.org/node/3070687

Adding correct patch file.

Patch #23 works for me.

drupal-check -d web/modules/contrib/r4032login
15/15 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

Works like a charm!

Works for me, too.
I would welcome an official release.

:-)

A new release for D9 would be great indeed :)

Or even just a commit to a dev branch! :)

For those who need to use this module with Drupal 9 now, feel free to use my fork (which has the patch committed):

{
    "repositories": {
        "r4032login": {
            "type": "vcs",
            "url": "git@github.com:grasmash/drupal-r4032login.git"
        }
    },
    "require": {
        "drupal/r4032login": "8.x-1.x-dev"
    }
}

Hello,

Thanks everyone for working on this.

From what I see, only maintainers action is needed now. Or am I missing something?

Is a new maintainer needed for the module? Because none has replied to this issue or #3148547: Automated Drupal 9 compatibility fixes.

Thanks you everyone.

I take the point this morning :

• New branch 2.x for the new version compatible with drupal 8 and drupal 9
• Check if test pass on drupal 8 and drupal 9 with this patch
• If all tests are ok, I'll create a new release 2.0.0

I committed directly to the 2.x branch the .info modification so I hope I can run test without composer error then.

I attach the reroll patch without the .info modification part.

We need to adapt fuctionnal test by adding default theme as required by https://www.drupal.org/node/3083055.

Thanks!

Excellent!