Problem/Motivation

drupal-check results on commit hash: e5c1c4047f5f1522e5d630bca93d50c61ef6a2c0



 ------ ------------------------------------------------------------------------------- 
  Line   src/Tests/PhpFilterTest.php                                                    
 ------ ------------------------------------------------------------------------------- 
  17     Call to deprecated function entity_load().                                     
  38     Call to deprecated method link() of class Drupal\Core\Entity\EntityInterface.  
 ------ ------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   src/Tests/Plugin/views/PhpArgumentValidatorTest.php                                
 ------ ----------------------------------------------------------------------------------- 
  16     Class Drupal\php\Tests\Plugin\views\PhpArgumentValidatorTest extends deprecated    
         class Drupal\views\Tests\ViewKernelTestBase.                                       
  36     Call to method setUp() of deprecated class Drupal\views\Tests\ViewKernelTestBase.  
 ------ ----------------------------------------------------------------------------------- 

 [ERROR] Found 4 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3042743-tests-13.patch3.41 KBgábor hojtsy
#12 3042743-tests.patch2.3 KBgábor hojtsy
#10 3042743.patch1.62 KBgábor hojtsy
#8 3042743-d9-8.patch9.28 KBrobertwb
#5 3042743-d9-5.patch8.84 KBfgm
#4 php-3042743-4.patch2.05 KBamateichuk
#2 php-3042743-2.patch1.29 KBdaiwik.addweb

Comments

mcdwayne created an issue. See original summary.

daiwik.addweb’s picture

daiwik.addweb commented
Status: Active » Needs review
StatusFileSize
new php-3042743-2.patch1.29 KB

@mcdwayne, Here's the patch for the same, hope this will work for you as per your requirement.

Thanks

Status: Needs review » Needs work

The last submitted patch, 2: php-3042743-2.patch, failed testing. View results

amateichuk’s picture

amateichuk commented
Status: Needs work » Needs review
StatusFileSize
new php-3042743-4.patch2.05 KB
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Title: Drupal 9 Deprecated Code Report » Drupal 9 Support
StatusFileSize
new 3042743-d9-5.patch8.84 KB

Rerolled with more fixes. Remaining issues are about switching from WebTestBase to BrowserTestBase.

PHP Filter, --
Scanned on Thu, 2020-06-04 09:06

FILE: web/modules/contrib/php/src/Tests/PhpTestBase.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        13   Class Drupal\php\Tests\PhpTestBase extends deprecated class
                    Drupal\simpletest\WebTestBase. Deprecated in drupal:8.8.0
                    and is removed from drupal:9.0.0. Instead, use
                    Drupal\Tests\BrowserTestBase. See
                    https://www.drupal.org/node/3030340. Replacement available
                    from drupal:8.6.0.
--------------------------------------------------------------------------------
Fix now        28   Call to method setUp() of deprecated class
                    Drupal\simpletest\WebTestBase. Deprecated in drupal:8.8.0
                    and is removed from drupal:9.0.0. Instead, use
                    Drupal\Tests\BrowserTestBase. See
                    https://www.drupal.org/node/3030340. Replacement available
                    from drupal:8.6.0.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/php/src/Tests/PhpUninstallTest.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        12   Class Drupal\php\Tests\PhpUninstallTest extends deprecated
                    class Drupal\simpletest\WebTestBase. Deprecated in
                    drupal:8.8.0 and is removed from drupal:9.0.0. Instead, use
                    Drupal\Tests\BrowserTestBase. See
                    https://www.drupal.org/node/3030340. Replacement available
                    from drupal:8.6.0.
--------------------------------------------------------------------------------
Fix now        25   Call to method setUp() of deprecated class
                    Drupal\simpletest\WebTestBase. Deprecated in drupal:8.8.0
                    and is removed from drupal:9.0.0. Instead, use
                    Drupal\Tests\BrowserTestBase. See
                    https://www.drupal.org/node/3030340. Replacement available
                    from drupal:8.6.0.
--------------------------------------------------------------------------------
japerry’s picture

japerry
Location KOMK
commented

This may sound brash, but I don't think it should support Drupal 9. This is a good time for people to stop bad coding practices ;)

tjtj’s picture

tjtj commented

How does one apply the patch in #5 which goes into many different directories?

robertwb’s picture

robertwb commented
StatusFileSize
new 3042743-d9-8.patch9.28 KB

Patch in #5 fails against the July 2020 release of Drupal 9 because it uses a deprecated argument for @entity.manager -- re-rolled patch attached.

tjtj’s picture

tjtj commented

Sorry to be dumb, But how does one apply this patch that fixes multiple files?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 3042743.patch1.62 KB

Rerolled following these.

  • Gábor Hojtsy committed 45962bd on 8.x-1.x 
    Issue #3042743 by Tolyan4ik, RoshniPatel.addweb, fgm, Gábor Hojtsy,...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 3042743-tests.patch2.3 KB

Let's see WTB, this will likely fail due to different methods.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 3042743-tests-13.patch3.41 KB

Cast condition results for test.

  • Gábor Hojtsy committed ee469ef on 8.x-1.x 
    Issue #3042743 by Gábor Hojtsy: Followup test updates for Drupal 9...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Ok that was easier than expected. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.