Closed (fixed)
Project:
U.S. Web Design System (USWDS)
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Mar 2019 at 13:08 UTC
Updated:
29 Apr 2019 at 20:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
fskreuz commentedComment #3
brockfanning commented@fskreuz Thanks for the heads up. Are your changes based on the newly-created 8.x-2.0-alpha1 branch of this Drupal theme? Or are they based on the 8.x-1.0-beta3 branch? Just wanted to clarify that.
But either way you are always welcome to post a patch. That may be the best way to get the conversation started.
Comment #4
fskreuz commentedIt's based on 8.x-2.0-alpha1. Attached is patch.
Summary of changes:
- Changed all component classes to BEM (because beta 6 changes).
- Removed the addition of the search box. See https://www.drupal.org/project/uswds/issues/3040374
- Removed the Paragraphs edge-to-edge logic. See https://www.drupal.org/project/uswds/issues/3039814.
- Removed the Mobile Menu region. See https://www.drupal.org/project/uswds/issues/3039817
Comment #5
Irisibk commented@fskreuz, thanks for posting the patch & for all the work you've done on this. I also have a patch for integrating the beta-6 changes which I will post up here so we can review how to merge both patches.
I am still reviewing your patch but thanks for catching the section in page.html.twig that has the page.help region commented out. That was an oversight.
I have a question about the addition on the block.html.twig template. From my understanding, this will cause all blocks to be rendered with a USWDS accordion component by default. Is that the intention?
Comment #6
Irisibk commentedThis patch is Work-in-progress. The ideal fix for this issue should probably be a combination of both patches in #4 and #6. I'm currently working on merging them.
Comment #7
Irisibk commentedComment #8
fskreuz commented@Irisibk yes, that was (sort of) the intention.
I needed to style blocks with a prominent header and bounded content in a way that fits with the USWDS scheme. In Bootstrap, cards would have been the perfect component for this. However, USWDS currently doesn't have cards. The closest the library has is an uncollapsible accordion. So I went with that.
As a side-effect, this would also easily give blocks the ability to collapse content, similar to what this module does https://www.drupal.org/project/collapsiblock
I'm not married to the idea tho. We can remove that in favor of overriding block templates as needed.
Comment #9
Irisibk commentedThanks @fskreuz, that does make sense.
Making the blocks collapsible sounds like good feature to have. I will test it further locally.
Like @brockfanning suggested in other issues, it would be great to separate out the features like disabling the search box, collapsible blocks, removing the mobile menu region etc. into patches & attach them to their respective issues so they can be reviewed individually.
Once I am done with merging the 2 patches here into one patch that reflects just the USWDS beta-6 updates, I will create a new issue for collapsible blocks and add the new block template to it. Please let me know if you have some time to upload patches into any of the existing issues. If not, when I am done with the above 2 tasks I will also go ahead and try to separate the remaining code in your patch into the other issues.
Comment #10
fskreuz commented@Irisibk I can look into creating the patches for the other issues after your merge. This way, I can work on top of the beta-6 stuff.
Comment #11
fskreuz commentedComment #12
fskreuz commentedBeta 7 just released today https://v2.designsystem.digital.gov/about/releases/#version-200-beta-7-r...
And it's an RC!
Was polishing up code for another patch submission this morning when I found out about the release. Will use beta 7 going forward.
Comment #13
fskreuz commentedTook me a while to realize that it's less effort to remove unneeded code first before applying beta changes, than the other way around (update the whole theme to the new beta changes only to remove some of it in the end).
Attached is the patch of beta 6 changes and works on top of the following patches (not included in this patch):
- https://www.drupal.org/project/uswds/issues/3039814
- https://www.drupal.org/project/uswds/issues/3040374
- https://www.drupal.org/project/uswds/issues/3039817
Will update to beta 7 soon. Still reading through what changed and if any apply to the theme.
Comment #14
fskreuz commentedComment #15
rromore commentedI've applied the 3 patches in 3039814, 3040374, and 3039817 as well as #13 and haven't seen any issues so far. I also went through the release changes for the beta 7 release on https://v2.designsystem.digital.gov/about/releases/ and didn't see any breaking changes in the code with the four patches applied. Thanks @fskreuz, @irisibk, and @brockfanning for all of the work you've done!
Comment #16
fskreuz commentedAttached is another patch including fixes related to search input, form grouping, and secondary menu region placement.
Comment #17
fskreuz commentedComment #18
fskreuz commentedVersion 2.0 has been released (https://v2.designsystem.digital.gov/about/releases/). Not a lot of changes since beta 7.
Attached is the patch for 2.0. It works on top of the following, so apply these first.
- https://www.drupal.org/project/uswds/issues/3040374 (removing core search)
- https://www.drupal.org/project/uswds/issues/3039817 (removing mobile menu)
The paragraphs removal patch was removed in favor of improving it in the theme. Apply both if you use uswds_paragraphs.
- https://www.drupal.org/project/uswds_paragraphs/issues/3046140 (remove styling from uswds_paragraphs)
- https://www.drupal.org/project/uswds/issues/3046222 (styling for uswds_paragraphs)
Comment #20
Irisibk commented