Problem/Motivation

String "Circular reference detected" is not translated.
File: /src/EntityClone/Content/ContentEntityCloneFormBase.php - 163

Proposed resolution

Use: $this->translationManager->translate('Circular reference detected')

Remaining tasks

  1. Create patch
  2. Review/RTBC
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 entity_clone-markup_translation-3037907-2.patch707 bytesi-trokhanenko

Comments

i-trokhanenko created an issue. See original summary.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: i-trokhanenko » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new entity_clone-markup_translation-3037907-2.patch707 bytes

Please review!

Roman Dyn’s picture

Roman Dyn commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Just checked patch #2 and installed with composer. Translation works fine. Please commit.

  • vpeltot committed 69cd344 on 8.x-1.x authored by i-trokhanenko 
    Issue #3037907 by i-trokhanenko: Markup in form element circular is not...
vpeltot’s picture

vpeltot commented
Status: Reviewed & tested by the community » Fixed

Commited !
Thanks

vpeltot’s picture

vpeltot commented

A new beta3 release was created with this issue solved.

https://www.drupal.org/project/entity_clone/releases/8.x-1.0-beta3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.