vartheme is providing a fix that applies a top padding to body via javascript to ensure that the toolbar is not overflowing content.

This fix is provided with "global-scripts" library (js/scripts.js) in vartheme. When creating a subtheme there is an own global-scripts library created in the subtheme but the script used in the subtheme does not provide the fix for the toolbar.

I think the script.js in subtheme should apply this fix too.

There is also something done about IPE tray padding in this script, that should probably put into the subtheme too.

I am providing patch that just copies these fixes to subtheme template too.

But maybe it would make sense to put this fixes out to separate library and inherit this from base theme? Since the global-scripts library is indicating to be a place for customizations?

Comments

stefan.korn created an issue. See original summary.

stefan.korn’s picture

Assigned: stefan.korn » Unassigned
Status: Active » Needs review
StatusFileSize
new910 bytes

This is the patch

rajab natshah’s picture

Thank you Stefan for reporting and the patch.
You are right on the issue.

We could apply your patch
But I have noticed that
vartheme/global-scripts: false
is off
I will comment it only so that we will load the Vartheme global scripts in the sub theme.

rajab natshah’s picture

rajab natshah’s picture

Title: vartheme subtheme does not use the toolbar top space fix from base theme » Fix vartheme subtheme does not use the toolbar top space issue as it is fix from base theme
rajab natshah’s picture

Title: Fix vartheme subtheme does not use the toolbar top space issue as it is fix from base theme » Fix vartheme subtheme does not use the toolbar top space issue as it was fixed from base theme

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue tags: +varbase-8.6.8
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.