I believe the travis analysis in README.md is obsolete due to the repo https://github.com/drupal-media/crop being read only. It should be removed from README.md

CommentFileSizeAuthor
#5 Removed_travis_info-3033552-5.patch680 bytesSahana _N
#4 remove_travis_info-3033552-2_patch_screenshot.png7.43 KBEitisha
#2 Remove_travis_info-3033552-1.patch585 bytesSahana _N
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oknate created an issue. See original summary.

Sahana _N’s picture

Sahana _N CreditAttribution: Sahana _N at Specbee commented
Status: Active » Needs work
FileSize
Remove_travis_info-3033552-1.patch585 bytes

Removed Travis info from README.md, please review

Sahana _N’s picture

Sahana _N CreditAttribution: Sahana _N at Specbee commented
Status: Needs work » Needs review
Eitisha’s picture

Eitisha CreditAttribution: Eitisha commented
FileSize
remove_travis_info-3033552-2_patch_screenshot.png7.43 KB

Hi Sahana,

I applied the patch and the patch is clean . Found one whitespace error only.

Attached is the screenshot.

Sahana _N’s picture

Sahana _N CreditAttribution: Sahana _N at Specbee commented
Issue summary: View changes
FileSize
Removed_travis_info-3033552-5.patch680 bytes

White spaces are removed please review

fayedm’s picture

fayedm CreditAttribution: fayedm at Kanopi Studios commented
Assigned: Unassigned » fayedm

I am a new contributor, reviewing this patch.

fayedm’s picture

fayedm CreditAttribution: fayedm at Kanopi Studios commented
Assigned: fayedm » Unassigned
Status: Needs review » Reviewed & tested by the community

Patch is clean and the whitespace is removed.

Marking RTBC.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

I agree. The GitHub repo is pretty much done, so keeping its Travis CI badge in README doesn't make a lot of sense. Adjusting credit for commit.

  • phenaproxima committed 44d7015 on 8.x-2.x 
    Issue #3033552 by Sahana _N, Eitisha, fayedm: Remove travis info...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.