Problem/Motivation

Not best practice to use the procedural t() in OOP Code.
File: src/Plugin/views/exposed_form/Autosubmit.php

Proposed resolution

Use $this->t();
See:
https://www.drupal.org/docs/8/api/translation-api/overview
https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/function/t/8.6.x

Remaining tasks

  1. Create patch
  2. Review/RTBC
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 views_autosubmit-fixed_t-3028371-2.patch704 bytesi-trokhanenko

Comments

i-trokhanenko created an issue. See original summary.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: i-trokhanenko » Unassigned
Status: Active » Needs review
StatusFileSize
new views_autosubmit-fixed_t-3028371-2.patch704 bytes

Please review.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Issue summary: View changes
Roman Dyn’s picture

Roman Dyn commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Reviewed views_autosubmit-fixed_t-3028371-2.patch. Patch applied successfully, works well for me. Please commit it. Thanks.

  • i-trokhanenko committed 3009c71 on 8.x-1.x 
    Issue #3028371 by i-trokhanenko, Roman Dyn: Use $this->t() instead of t...
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.