Problem/Motivation
Reroute Email shows a strange message for the user if rerouting address is empty.
Steps to reproduce:
1. Enable Reroute Email module.
2. Enable Rerouting and leave empty "Rerouting email addresses" field.
3. Send an email somehow.
Result:
{message_id} was aborted by reroute email; site administrators can check the recent log entries for complete details on the rerouted email.
Proposed resolution
Add a condition to make sure "Display a Drupal status message after rerouting submitted email" checkbox is enabled.
Remaining tasks
Attach a patch.
User interface changes
None
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | reroute_email-dsm_checkbox_ignored-3022345-7-D8.patch | 1.7 KB | sershevchyk |
| #2 | reroute_email-dsm_checkbox_ignored-3022345-2-D7.patch | 842 bytes | matroskeen |
Comments
Comment #2
matroskeenHere is the patch.
Comment #3
bohartIn that case, the description of `REROUTE_EMAIL_ENABLE_DSM` variable should be updated as well.
> Check this box if you would like a Drupal status message to be displayed to users after submitting an email to let them know it was rerouted to a different email address.
Should be smth like:
> Check this box if you would like a Drupal status message to be displayed to users after submitting an email to let them know it was aborted to send or rerouted to a different email address.
Comment #5
bohartCommitted to 7.x-1.x.
No need for test coverage.
Should be ported to D8.
Marked as `Patch (to be ported)`.
@matroskeen, thanks for your contribution!
Comment #6
sershevchykAdded condition for display message for users only if the checkbox "Display a Drupal status message after rerouting" was enabled.
Comment #7
sershevchykUpdated description
Comment #9
bohartFinally committed to both 7.x-1.x and 8.x-1.x.
No need for test coverage.
Marked as Fixed. Thanks @all!