Problem/Motivation

Reroute Email shows a strange message for the user if rerouting address is empty.

Steps to reproduce:
1. Enable Reroute Email module.
2. Enable Rerouting and leave empty "Rerouting email addresses" field.
3. Send an email somehow.

Result:
{message_id} was aborted by reroute email; site administrators can check the recent log entries for complete details on the rerouted email.

Proposed resolution

Add a condition to make sure "Display a Drupal status message after rerouting submitted email" checkbox is enabled.

Remaining tasks

Attach a patch.

User interface changes

None

API changes

None

Data model changes

None

Comments

Matroskeen created an issue. See original summary.

matroskeen’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new842 bytes

Here is the patch.

bohart’s picture

Status: Needs review » Needs work

In that case, the description of `REROUTE_EMAIL_ENABLE_DSM` variable should be updated as well.

> Check this box if you would like a Drupal status message to be displayed to users after submitting an email to let them know it was rerouted to a different email address.

Should be smth like:

> Check this box if you would like a Drupal status message to be displayed to users after submitting an email to let them know it was aborted to send or rerouted to a different email address.

  • bohart committed 2fbc263 on 7.x-1.x authored by Matroskeen
    Issue #3022345 by Matroskeen, bohart: "Display a DSM" checkbox is...
bohart’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs work » Patch (to be ported)

Committed to 7.x-1.x.
No need for test coverage.

Should be ported to D8.
Marked as `Patch (to be ported)`.

@matroskeen, thanks for your contribution!

sershevchyk’s picture

Issue tags: +LutskGCW19
StatusFileSize
new822 bytes

Added condition for display message for users only if the checkbox "Display a Drupal status message after rerouting" was enabled.

sershevchyk’s picture

StatusFileSize
new1.7 KB

Updated description

  • bohart committed 8f6efa7 on 8.x-1.x authored by Shefarik
    Issue #3022345 by Shefarik, bohart: "Display a DSM" checkbox is ignored...
bohart’s picture

Status: Patch (to be ported) » Fixed

Finally committed to both 7.x-1.x and 8.x-1.x.
No need for test coverage.

Marked as Fixed. Thanks @all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.