Unable to delete email template without also deleting workflow if it has been associated

I've run into this as well with 8.x-1.1 from 2/25/19.

One possibility is that we simply block deletion of a template as long as it is being referenced by a workflow. Leave it to the user to clear up the dependency.

An alternative would be to add transitions to the template rather than adding templates to the transition. I think it makes more sense that way as that way we're not altering existing config and you can safely remove this module without affecting the transitions. Or have a separate config that maps templates and transitions.

This also affects the ability to uninstall this module. If you uninstall the module, all your workflows are deleted.

An alternative would be to add transitions to the template rather than adding templates to the transition.

I like this idea, I always find it odd having to go to a separate screen to wire the transition -> the email template.

thank god for version control. hopefully this will be fixed soon. deleting the workflow makes no sense. just update the workflow if the email template is deleted to remove that enforced dependency.

Let's go with #6

Here's a really rough start.

Working:

• Transitions can be configured on the template form and are saved and loaded.

Not working:

• Everything else

Please note that I have also not been able to disable a template for a particular workflow. If I disable it either in the workflow settings or the email template settings, it re-appears...

Eric

I guess we need an update hook for existing config

Looks great, left a code review

I tested this locally on an existing project - the UI works as expected as do the dependencies

We could add an update path test here, but they've been tricky to maintain in the past, as you need to update for each major version of core.

One thing I noticed in the update path, is we didn't end up resolving the forced config dependency

e.g. the workflow still has

enforced:
     config:
       - workbench_email.workbench_email_template.needs_review

So we'll need to update that in the update path too.

🎉Fixed, this will go out as 3.0.0