Internal links are no longer recognized correctly when using version 7.20 of this module on a site that is hosted at a URL that contains a port number (e.g. www.domain.com:1234).
This seems to be related to the fact that the fix that was committed for the 7.x issue, #2962335-10: External link icon not always shown after update to 7.x-1.19, did not account for the port number component of the URL like the fix that was committed for the 8.x issue, #2914838-21: (Sub-)domain detection not reliable., did.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | urls_containing_port-3004486-7.patch | 529 bytes | joegraduate |
| #4 | urls_containing_port-3004486-4.patch | 541 bytes | joegraduate |
Comments
Comment #2
joegraduateComment #3
joegraduateComment #4
joegraduateThe attached patch applies cleanly to the 7.x-1.x branch / 7.x-1.x-dev version of the module and fixes the issue for me.
Comment #5
joegraduateThe attached patch fixes the issue for me.
Comment #6
trackleft2The patch in comment #4 fixes the issue for me too! Thanks!
Comment #7
joegraduateThis patch applies cleanly to the 7.x-1.20 version of the module. The patch in #4 is what should be committed but this version is useful for anyone currently affected by the issue using version 7.x-1.20.
Comment #9
joegraduatePatch in #4 passes tests and is ready for review.
Comment #10
bkosborneWorks for me.
Comment #11
chris matthews commentedThank you for this patch! I know that 7.x-1.20 was recently released in April, but I was hoping a 7.x-1.21 release could be tagged, which of course includes the patch in #4.
thanks,
Comment #13
elachlan commentedThanks!