Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

Assigned: alonaoneill » Unassigned
Status: Active » Reviewed & tested by the community
StatusFileSize
new973 bytes

I uploaded a patch that Capitalize the name of the module and dependency namespacing in the .info.yml file.
Thanks!

volkswagenchick’s picture

StatusFileSize
new11.99 KB

Code looks good - looks like a similar issue was posted: https://www.drupal.org/project/acquia_connector/issues/3001530 - thought htis one addresses the submodule as well.
Patch applied using simplytest.me. screenshot attached. marking RTBC

danepowell’s picture

Status: Reviewed & tested by the community » Fixed

Thanks a lot for the contributions. I have committed this change.

volkswagenchick’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.