Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Screen Shot 2018-09-24 at 3.31.01 PM.png | 11.99 KB | volkswagenchick |
| #2 | acquia_connector-info-3002073-2.patch | 973 bytes | alonaoneill |
Comments
Comment #2
alonaoneill commentedI uploaded a patch that Capitalize the name of the module and dependency namespacing in the .info.yml file.
Thanks!
Comment #3
volkswagenchickCode looks good - looks like a similar issue was posted: https://www.drupal.org/project/acquia_connector/issues/3001530 - thought htis one addresses the submodule as well.
Patch applied using simplytest.me. screenshot attached. marking RTBC
Comment #4
danepowell commentedThanks a lot for the contributions. I have committed this change.
Comment #5
volkswagenchick