While evaluating this module I noticed that on the Extend page, the project name is in lower case and should be in title case to be consistent with the rest of the project names on the page.

"Capitalize the name of the module, because module names are proper nouns."

https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...

Patch to follow, thanks!

CommentFileSizeAuthor
#3 Screen Shot 2018-09-21 at 9.25.57 AM.png13.68 KBJQTNguyen
#2 acquia_connector-capitalize-3001530-2.patch381 bytesvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Version: 8.x-2.x-dev » 8.x-1.x-dev
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new acquia_connector-capitalize-3001530-2.patch381 bytes

I uploaded a patch that capitalizes the name of the module

JQTNguyen’s picture

JQTNguyen commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2018-09-21 at 9.25.57 AM.png13.68 KB

Changes look good in the UI (see screenshot), name capitalization aligns with Drupal Standards, and patch applied without errors using Simplytest.Me. Marking RTBC.

danepowell’s picture

danepowell commented
Status: Reviewed & tested by the community » Closed (duplicate)

Thanks a lot for the contribution, I'm going to roll this into the more comprehensive #3002073: Capitalize the name of the submodule and dependency namespacing in .info.yml file but I'll be sure to give you credit for the patch.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented