In the case where the coordinates are filled by the user, do not replace the coordinates.

CommentFileSizeAuthor
#6 geocoder-option-to_skip-not-null-destination-3001178-6.patch1.99 KBitamair
#5 ignore-geocoder-coordinates-manually-set-3001178-5.patch1.67 KBklaasvw
#4 geocoder-leave-existing-coords.patch1.66 KBnightlife2008
#2 ignore-geocoder-coordinates-manually-set-3001178-2.patch1.5 KBnetsliver

Comments

netsliver created an issue. See original summary.

netsliver’s picture

netsliver
Primary language French
Location Chelles
commented
StatusFileSize
new ignore-geocoder-coordinates-manually-set-3001178-2.patch1.5 KB
itamair’s picture

itamair commented

tnx @netsliver ... will review this asap

nightlife2008’s picture

nightlife2008 commented
StatusFileSize
new geocoder-leave-existing-coords.patch1.66 KB

I refactored the provided patch to avoid unnecessary geocoding.

klaasvw’s picture

klaasvw commented
StatusFileSize
new ignore-geocoder-coordinates-manually-set-3001178-5.patch1.67 KB

Thanks all, this is working great.

Note that we had one issue when applying the patch to an existing installation. A PHP notice is thrown for fields that don't have the skip_not_empty_gps option set.

The attached patch is a reroll of #4 with an empty check to prevent the notice.

itamair’s picture

itamair commented
Status: Needs review » Fixed
StatusFileSize
new geocoder-option-to_skip-not-null-destination-3001178-6.patch1.99 KB

thanks all ...
I reviewed and tested the #5 ... and I had to amend it to make it more general (it regards the target value in general and not only a geofield / coordinates target one). I also changed the element index accordingly and added some comment and better description to user and contributor.
The attached patch wraps the issue feature request and is going to be committed into dev right now.

  • itamair committed 0f37cb4 on 8.x-2.x 
    Issue #3001178 by netsliver, itamair, nightlife2008, klaasvw: Ignore...

  • itamair committed 684f8b8 on 8.x-3.x 
    Issue #3001178 by netsliver, itamair, nightlife2008, klaasvw: Ignore...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.