Problem/Motivation

The update module has a number of test fixtures that emulate Drupal.org's XML update data:

core/modules/update/tests/modules/update_test/drupal.sec.0.1_0.2.xml
core/modules/update/tests/modules/update_test/drupal.sec.0.2-rc2-b.xml
core/modules/update/tests/modules/update_test/drupal.sec.0.2-rc2.xml
core/modules/update/tests/modules/update_test/drupal.sec.0.2.xml
core/modules/update/tests/modules/update_test/drupal.sec.1.2.xml
core/modules/update/tests/modules/update_test/drupal.sec.1.2_insecure.xml

Most of these are named for the latest releases included in the update data. However, two fixtures added in #2990511: Add comprehensive test coverage for update status for security releases seem to be misnamed:

core/modules/update/tests/modules/update_test/drupal.sec.0.2-rc2-b.xml
and
core/modules/update/tests/modules/update_test/drupal.sec.0.2-rc2.xml

In these two fixtures, the latest release is 8.2.0-rc2, not 8.0.2-rc2. This led to a little confusion during the review process.

Proposed resolution

Rename the fixtures.

Remaining tasks

Confirm that the fixtures should in fact be renamed, rename them, and update the tests that use them.

User interface changes

None.

API changes

Text fixtures are renamed (internal API change for a very recent commit; does not need a CR).

Data model changes

None.

CommentFileSizeAuthor
#9 2995367-9.patch5.59 KBquietone

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +MWDS2018
xjm’s picture

xjm
she/her
Primary language English
commented
Related issues: +#2909665: [plan] Extend security support to cover the previous minor version of Drupal

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Priority: Normal » Minor
Issue tags: +Novice, +Bug Smash Initiative
quietone’s picture

quietone commented
Version: 9.3.x-dev » 9.4.x-dev
Status: Active » Needs review
StatusFileSize
new 2995367-9.patch5.59 KB

I'm working through a list of issue related to updates so even though this is tagged novice I'd like to work on this.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Looks good, checked some of the others and it does seem that these are the only files affected by this.

  • xjm committed 7666d52 on 10.0.x 
    Issue #2995367 by quietone, xjm, Lendude: Fix update module test fixture...

  • xjm committed 3fe2e7f on 9.5.x 
    Issue #2995367 by quietone, xjm, Lendude: Fix update module test fixture...

  • xjm committed f90d5a2 on 9.4.x 
    Issue #2995367 by quietone, xjm, Lendude: Fix update module test fixture...

  • xjm committed 6c6fbed on 9.3.x 
    Issue #2995367 by quietone, xjm, Lendude: Fix update module test fixture...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to... let's just say lots of branches. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.