Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

CommentFileSizeAuthor
#6 owlcarousel-info-2994442-3.patch444 bytesjoy29
#2 owlcarousel-info-2994442-2.patch372 bytesalonaoneill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
FileSize
owlcarousel-info-2994442-2.patch372 bytes

I uploaded a patch that corrects the Capitalization and dependency namespacing in the .info.yml file.
Thanks!

dani3lr0se’s picture

dani3lr0se CreditAttribution: dani3lr0se at Hook 42 commented

Thanks for the patch @alonaoneill. For some reason the patch failed to apply for me locally and the project isn't recognized by simplytest yet so it can't be tested there. Not sure why it didn't apply. It looks ok to me.

dani3lr0se’s picture

dani3lr0se CreditAttribution: dani3lr0se at Hook 42 commented
Status: Needs review » Needs work
srhcpa@debitsandcredits.com’s picture

srhcpa@debitsandcredits.com CreditAttribution: srhcpa@debitsandcredits.com commented

Hi Runranil,

When I ran this patch, I get the error: "No such file or directory".

I copied the patch to my public_html and ran this "git apply --ignore-space-change --ignore-whitespace owlcarousel-info-2994442-3.patch" from public_html.

Why do you think I am I getting this error?

Stephen

Hi Alona,

How do I run this patch? Can you give me a few instructions, please?

Stephen

joy29’s picture

joy29 CreditAttribution: joy29 commented
Component: Code » Documentation
Assigned: Unassigned » joy29
FileSize
owlcarousel-info-2994442-3.patch444 bytes

Please apply this patch in the following format it will ignore whitespaces and space-changes in a file. In this way work for me

git apply --ignore-space-change --ignore-whitespace owlcarousel-info-2994442-3.patch

joy29’s picture

joy29 CreditAttribution: joy29 commented
Status: Needs work » Needs review
ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented
Status: Needs review » Reviewed & tested by the community

Thanks guys

ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented

  • ipwa committed 4859525 on 8.x-1.x 
    Issue #2994442 by alonaoneill, rudranil29, ipwa: Capitalize the name of...
ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.